feat:added new tab called all obligation by Anushreebasics · Pull Request #1316 · eclipse-sw360/sw360-frontend

Anushreebasics · 2026-01-06T10:06:12Z

Proposed Changes:

[Component Name] Obligations Management
[MODIFY]
Obligations.tsx
Add a new Nav.Item for "All Obligations".
Add a new Tab.Pane to render the AllObligationsView component.
[NEW]
AllObligationsView.tsx
Create a new component that fetches and displays obligations from sub-projects.
Fetch sub-projects using projects/${projectId}/linkedProjects?transitive=true.
Fetch obligations for each sub-project.
Filter obligations where status is ACKNOWLEDGED_OR_FULFILLED or FULFILLED_AND_PARENT_MUST_ALSO_FULFILL.
If status is FULFILLED_AND_PARENT_MUST_ALSO_FULFILL, verify the parent project also has a fulfilled obligation of the same type (this logic might need refinement based on exact requirements).
Display the aggregated list in a SW360Table.

@GMishx @heliocastro @kairoaraujo @amritkv please review this PR

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

heliocastro · 2026-01-15T19:58:01Z

@Anushreebasics will you fix this build or should we close the PR ?

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/app/[locale]/projects/components/Obligations/Obligations.tsx

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

Anushreebasics · 2026-01-16T07:57:27Z

@heliocastro I have fixed the build, please review

Anushreebasics · 2026-01-19T04:19:32Z

@heliocastro @amritkv please review

package.json

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

deo002 · 2026-01-20T07:57:57Z

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

+                cell: ({ row }) => (
+                    <span>
+                        {row.original.projectName}{' '}
+                        {row.original.projectVersion ? `(${row.original.projectVersion})` : ''}


This field should have the entire project path. Like, if it is a sub-project the entry should be: Project -> SubProject1 -> SubProject2

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

deo002 · 2026-01-20T08:55:13Z

Feel free to reach out in case you need any clarifications!

Anushreebasics · 2026-01-20T09:52:02Z

@deo002 please review the changes

amritkv · 2026-01-28T09:25:57Z

Hey @Anushreebasics !
Please fix the linting errors of Biome.

Anushreebasics · 2026-01-28T10:19:10Z

@amritkv please review the changes

Anushreebasics · 2026-01-28T16:15:45Z

@heliocastro please review

amritkv · 2026-01-29T18:57:29Z

Hey @Anushreebasics !
Please add the translations for other languages as well.

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

deo002 · 2026-01-30T06:34:49Z

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

+                    Object.entries(obs).forEach(([title, detail]) => {
+                        if (detail.status && fulfilledStatuses.includes(detail.status)) {
+                            let parentFulfillmentOk = true
+                            if (detail.status === 'FULFILLED_AND_PARENT_MUST_ALSO_FULFILL') {


I do not think this is required, we checked the status of obligation in the parent if clause (line #283) right? Am I missing something?

The outer if clause checks if the current obligation's status is in the fulfilled statuses, but the inner check for the parent is only needed for the special case 'FULFILLED_AND_PARENT_MUST_ALSO_FULFILL'.
So, the parent check is not redundant—it is required for correct business logic.
If I remove it, it will incorrectly include obligations that should only be considered fulfilled if the parent is also fulfilled.

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

deo002 · 2026-01-30T07:30:47Z

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

+
+                            if (parentFulfillmentOk) {
+                                allAggregated.push({
+                                    ...detail,


Do we need anything else besides projectPath? Rest all fields will be present in detail right? The project name and version of all projects can be included in the projectPath itself.

yes we need it since projectPath only includes the project names in the hierarchy, separated by " -> ". It does not include the project version for each project and other details

src/app/[locale]/projects/components/Obligations/AllObligationsView.tsx

Anushreebasics · 2026-01-30T10:15:55Z

@deo002 please review the changes

Anushreebasics · 2026-02-17T08:30:11Z

@heliocastro please review

Copilot AI review requested due to automatic review settings January 6, 2026 10:06

Anushreebasics requested review from GMishx, amritkv and heliocastro as code owners January 6, 2026 10:06

Copilot started reviewing on behalf of Anushreebasics January 6, 2026 10:06 View session

Anushreebasics force-pushed the all-obligation branch from d8f7acf to 3834f92 Compare January 6, 2026 10:13

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Anushreebasics requested a review from Copilot January 16, 2026 04:28

Copilot started reviewing on behalf of Anushreebasics January 16, 2026 04:29 View session

Copilot AI reviewed Jan 16, 2026

View reviewed changes

Anushreebasics force-pushed the all-obligation branch 2 times, most recently from b87204e to f9ba940 Compare January 19, 2026 04:13

deo002 self-assigned this Jan 20, 2026

deo002 requested changes Jan 20, 2026

View reviewed changes

Anushreebasics force-pushed the all-obligation branch from dbef463 to 51eda7b Compare January 23, 2026 14:37

Anushreebasics requested a review from deo002 January 23, 2026 14:38

Anushreebasics force-pushed the all-obligation branch from 51eda7b to 14ed64b Compare January 23, 2026 14:47

Anushreebasics force-pushed the all-obligation branch 4 times, most recently from ed2498a to 8a52f93 Compare January 28, 2026 10:16

deo002 requested changes Jan 30, 2026

View reviewed changes

feat(obligations): add All Obligations tab and related improvements

7d198d3

Anushreebasics force-pushed the all-obligation branch from 9d31e4c to 7d198d3 Compare January 30, 2026 11:57

Anushreebasics requested a review from deo002 February 11, 2026 10:26

Conversation

Anushreebasics commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

heliocastro commented Jan 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Anushreebasics commented Jan 16, 2026

Uh oh!

Anushreebasics commented Jan 19, 2026

Uh oh!

Uh oh!

Uh oh!

deo002 Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deo002 commented Jan 20, 2026

Uh oh!

Anushreebasics commented Jan 20, 2026

Uh oh!

amritkv commented Jan 28, 2026

Uh oh!

Anushreebasics commented Jan 28, 2026

Uh oh!

Anushreebasics commented Jan 28, 2026

Uh oh!

amritkv commented Jan 29, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

deo002 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Anushreebasics Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

deo002 Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Anushreebasics Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Anushreebasics commented Jan 30, 2026

Uh oh!

Anushreebasics commented Feb 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Anushreebasics commented Jan 6, 2026 •

edited

Loading