Skip to content

fix(hooks): Guard useLocalStorage against invalid JSON #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YianZhao wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(hooks): Guard useLocalStorage against invalid JSON #1536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8af6d16
fix(hooks): Guard useLocalStorage against invalid JSON
YianZhao Mar 19, 2026
1ac6945
Merge branch 'main' into fix/localstorage-json-guard
amritkv Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/hooks/useLocalStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,12 +29,26 @@ function useLocalStorage<T>(
}

useEffect(() => {
const parseStoredItem = (item: string | null): T => {
if (item === null) {
return initialValue
}

try {
return JSON.parse(item) as T
} catch (error) {
console.error(error)
window.localStorage.removeItem(key)
return initialValue
}
}

const item = window.localStorage.getItem(key)
setStoredValue(item !== null ? (JSON.parse(item) as T) : initialValue)
setStoredValue(parseStoredItem(item))

const handleStorageChange = () => {
const currentItem = window.localStorage.getItem(key)
setStoredValue(currentItem !== null ? (JSON.parse(currentItem) as T) : initialValue)
setStoredValue(parseStoredItem(currentItem))
}

window.addEventListener('storage', handleStorageChange)
Expand Down
Loading