fix(vendors): fix search and pagination #3522
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bibhuti230185
requested review from
GMishx,
KoukiHama,
ag4ums,
arunazhakesan and
heliocastro
as code owners
GMishx
added
needs code review
needs general test
GMishx
requested changes
Nov 28, 2025
Member
GMishx
left a comment
GMishx
left a comment
There was a problem hiding this comment.
A suggestion to not have this function.
backend/common/src/main/java/org/eclipse/sw360/datahandler/db/VendorRepository.java
Outdated
Show resolved
Hide resolved
GMishx
force-pushed
the
fix/vendors/search-pagination
branch
from
66bf5fe to
d636809
Compare
GMishx
changed the title
GMishx
force-pushed
the
fix/vendors/search-pagination
branch
3 times, most recently
from
1399cb4 to
9287afa
Compare
bibhuti230185
force-pushed
the
fix/vendors/search-pagination
branch
from
681e9b0 to
f45a00a
Compare
GMishx
requested changes
Jan 12, 2026
Member
GMishx
left a comment
GMishx
left a comment
There was a problem hiding this comment.
One minor change. Rest looks good.
Fix the search for Vendors and make responses DB paginated. Signed-off-by: Gaurav Mishra <[email protected]>
bibhuti230185
force-pushed
the
fix/vendors/search-pagination
branch
from
f45a00a to
f42f5af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes :
Enhanced the VendorRepository to use view-based pagination with sorting. The key improvements include:
View Selection Logic: The getViewFromPagination() method maps sort column numbers to the appropriate CouchDB views (vendorbyfullname, vendorbyshortname, all)
Optimized Pagination: Uses queryViewPaginated() for better performance when sorting, with a fallback to index-based queries for reliability
Issue:
Suggest Reviewer
@GMishx
Note:
These changes also incorporate suggestions from apache/couchdb#5756