#312 Handle HTTP code 429 #313
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing. I just looked at this commit and it only seems to define a new constant NX_WEB_HTTP_STATUS_CODE_TOO_MANY_REQUESTS. I cannot see any code which uses that constant or provides handling of the "too many requests" case. Is there maybe something missing? |
Contributor
Author
|
Thanks for reviewing @hwmaier . Online 1618 of nx_web_http_cleint.c the array I modified on line 83 is searched to see if it contains the code returned by the server. If the code is not found, NX_WEB_HTTP_REQUEST_UNSUCCESSFUL_CODE is returned. If the code is found, it is eventually returned to the client calling _nx_web_http_client_response_body_get. |
joelguittet
reviewed
Apr 5, 2025
fdesbiens
added
the
discussion
Contributor
|
@eclipse-threadx/iot-threadx-committers: Can one of you review this PR, please? |
Contributor
Author
|
Is this ready to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.