Skip to content

Improves the robustness of integration test scripts#1163

Merged
sashacmc merged 2 commits intomainfrom
improve_local_testing
Mar 3, 2026
Merged

Improves the robustness of integration test scripts#1163
sashacmc merged 2 commits intomainfrom
improve_local_testing

Conversation

@sashacmc
Copy link
Member

@sashacmc sashacmc commented Feb 20, 2026

Description

This PR improves the robustness of integration test scripts for local development environments.

What does this PR do?

tests/routed.sh:

  • Fixes TESTDIR to use absolute path instead of relative path (prevents cp failures)
  • Adds cleanup for corrupted zenohd state from interrupted runs
  • Validates zenohd binary exists and is executable before use
  • Verifies zenohd process started successfully before running tests
  • Checks if process is running before attempting to terminate it

CMakeLists.txt:

  • Replaces configure_file() with file() for test scripts to explicit execute permissions on copied scripts

Why is this change needed?

The integration test scripts had several issues when running locally


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: internal

🏠 Internal Change

This PR is marked as internal (not user-facing):

  • No API changes - Public APIs unchanged
  • No behavior changes - External behavior identical
  • Refactoring/maintenance - Code improvements only
  • Tests still pass - All existing tests pass without modification

Lighter review: Internal changes may have lighter review requirements.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@sashacmc sashacmc added the internal Changes not included in the changelog label Feb 20, 2026
@sashacmc sashacmc marked this pull request as ready for review February 20, 2026 20:17
Copy link
Contributor

@gmartin82 gmartin82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sashacmc sashacmc force-pushed the improve_local_testing branch from ccc47e4 to 5064202 Compare March 3, 2026 18:00
@sashacmc sashacmc merged commit cfd4b51 into main Mar 3, 2026
164 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes not included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants