feat: ignore unknown configuration fileds #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriele Baldoni <[email protected]>
sashacmc
approved these changes
Mar 13, 2025
|
The drawback of this change will be that a typo in the config will be silently ignored. This could lead to lot of confusions. |
I agree, but I did not find a way to let Another solution can be to remove all the fields like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the behavior of the configuration parser to ignore unknown fields.
This allows to load the DDS plugin multiple times, and thus to connect to multiple DDS domains at once.
See how to load a plugin multiple times in Zenoh: eclipse-zenoh/zenoh#1060