feat: accumulation from grib-index #317
Conversation
| assert not kwargs | ||
| raise NotImplementedError("requests not implemented") | ||
|
|
||
| if kwargs: |
There was a problem hiding this comment.
Could we briefly explain why requests and kwargs are incompatible ?
| indexdb=use_grib_index, | ||
| flavour=None, | ||
| requests=requests, | ||
| request_already_using_valid_datetime=True, |
There was a problem hiding this comment.
request_already_using_valid_datetime isn't actually changing the behaviour of the code, as far as I can tell
|
|
||
| if requests is not None: | ||
| assert not kwargs | ||
| raise NotImplementedError("requests not implemented") |
There was a problem hiding this comment.
If we're not using it, why add it?
| raise NotImplementedError("requests not implemented") | ||
|
|
||
| if kwargs: | ||
| assert not requests |
There was a problem hiding this comment.
Because request_already_using_valid_datetime=True in the accumulation source, this will fail if requests is truthy – is it better to capture that error at that level rather than here? (I don't mind - just curious)
| ---------- | ||
| dates : List[Any] | ||
| List of dates to retrieve data for. | ||
| request_already_using_valid_datetime : bool, optional |
There was a problem hiding this comment.
request_already_using_valid_datetime is set to True in the accumulation code, has a default of False here - but there's no switch that changes the behaviour of the code. This feels incorrect to me
github-project-automation
bot
moved this from Now In Progress
to Under Review
in Anemoi-dev
4 participants
Description
Type of Change
Issue Number
Code Compatibility
Code Performance and Testing
Dependencies
Documentation
Additional Notes