-
Notifications
You must be signed in to change notification settings - Fork 45
feat: abstracting accumulation #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hello
Hello @frazane, happy it's been useful already. Sorry it took so long... I think the PR is ready for review as I added some docs and fixed some tiny bugs. Now I also want to add functionality for netcdf files, but i don't have a use-case myself. I will be using IMERG dataset for this, but if you have a different netcdf dataset/specific needs i'm happy to discuss it. |
@flyIchtus we are only using GRIB-based sources ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality is there and I tested it successfully on my machine. Comments are mostly related to docstrings and static typing.
Hi @flyIchtus, |
It should be, can we discuss it in DM ? |
for more information, see https://pre-commit.ci
This PR should go on top of (be merged after) this other one #379 which refactors a lot. I mention this becuase this PR changes |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ecmwf/anemoi-transform#168 may show a related use case. |
Description
Type of Change
Issue Number
Code Compatibility
Code Performance and Testing
Dependencies
Documentation
Additional Notes
📚 Documentation preview 📚: https://anemoi-datasets--326.org.readthedocs.build/en/326/