Review suggestions for PR #433 #436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #427. --- ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
<!--pre-commit.ci start--> updates: - [github.com/psf/black-pre-commit-mirror: 25.1.0 → 25.9.0](psf/black-pre-commit-mirror@25.1.0...25.9.0) - [github.com/pycqa/isort: 6.0.1 → 6.1.0](PyCQA/isort@6.0.1...6.1.0) - [github.com/astral-sh/ruff-pre-commit: v0.12.11 → v0.13.3](astral-sh/ruff-pre-commit@v0.12.11...v0.13.3) - [github.com/tox-dev/pyproject-fmt: v2.6.0 → v2.7.0](tox-dev/pyproject-fmt@v2.6.0...v2.7.0) <!--pre-commit.ci end--> --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
## Description Reduces the complexity of legacy sources by moving to straightforward class inheritance and implementation, removing the need for the decorator and dynamically generated classes. ***As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/*** By opening this pull request, I affirm that all authors agree to the [Contributor License Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
#316) …ions ## Description <!-- Provide a brief summary of the changes introduced in this pull request. --> ## Type of Change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update ## Issue Number <!-- Link the Issue number this change addresses, ideally in one of the "magic format" such as Closes #XYZ --> <!-- Alternatively, explain the motivation behind the changes and the context in which they are being made. --> ## Code Compatibility - [ ] I have performed a self-review of my code ### Code Performance and Testing - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I ran the [complete Pytest test](https://anemoi.readthedocs.io/projects/training/en/latest/dev/testing.html) suite locally, and they pass <!-- In case this affects the model sharding or other specific components please describe these here. --> ### Dependencies - [ ] I have ensured that the code is still pip-installable after the changes and runs - [ ] I have tested that new dependencies themselves are pip-installable. <!-- List any new dependencies that are required for this change and the justification to add them. --> ### Documentation - [ ] My code follows the style guidelines of this project - [ ] I have updated the documentation and docstrings to reflect the changes - [ ] I have added comments to my code, particularly in hard-to-understand areas <!-- Describe any major updates to the documentation --> ## Additional Notes <!-- Include any additional information, caveats, or considerations that the reviewer should be aware of. --> Co-authored-by: Aaron Hopkinson <[email protected]>
github-actions
bot
added
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves merge conflicts and fixes broken imports after reorganisation.
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.