fix: Remove assertion that assumes anemoi-core is installed from interpolator runner
#345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
radiradev
changed the title
anemoi-core is installed from interpolator runneranemoi-core is installed from interpolator runner
radiradev
changed the title
anemoi-core is installed from interpolator runneranemoi-core is installed from interpolator runner
radiradev
changed the title
anemoi-core is installed from interpolator runneranemoi-core is installed from interpolator runner
HCookie
reviewed
Oct 15, 2025
Comment on lines
80
to
82
| assert isinstance( | ||
| self.model.model, AnemoiModelEncProcDecInterpolator | ||
| ), "Model must be an interpolator model for this runner" |
There was a problem hiding this comment.
Do you think we need a check here at least? Maybe a class name check?
There was a problem hiding this comment.
So something like this?
assert self.model.model.__class__.__name__ == "AnemoiModelEncProcDecInterpolator", \
"Model must be an interpolator model for this runner"
There was a problem hiding this comment.
Also, how do you even not have anemoi-models installed? The de-seralisation should break no?
|
Addressed in #335 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#344
What problem does this change solve?
What issue or task does this change relate to?
Additional notes
As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.