Skip to content

Conversation

@b8raoult
Copy link
Collaborator

@b8raoult b8raoult commented Oct 2, 2025

Description

This prepare the ground for supporting OmegaConf substitutions in all YAML files (especially datasets and inference). The DotDict is now a subclass of the OmegaConf object, so we keep backward compatibility with existing code.

Note that the previous config.py has been split between config.py and settings.py, the former handling general config files, the latter handling user settings. Backward compatibility will be supported for a while, with deprecation warnings.

What problem does this change solve?

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Oct 2, 2025
@github-actions github-actions bot added dependencies Pull requests that update a dependency file tests labels Oct 2, 2025
@b8raoult b8raoult changed the title Feat/omegaconf feat: omegaconf based configs Oct 2, 2025
@b8raoult b8raoult marked this pull request as ready for review October 2, 2025 09:58
@b8raoult b8raoult requested a review from a team as a code owner October 2, 2025 09:58
floriankrb pushed a commit to ecmwf/anemoi-datasets that referenced this pull request Oct 6, 2025
## Description

Fix as a pre-requisite to ecmwf/anemoi-utils#223
because
the class hiearchy will change and the removed line created an
exception.

## What problem does this change solve?
<!-- Describe if it's a bugfix, new feature, doc update, or breaking
change -->

## What issue or task does this change relate to?
<!-- link to Issue Number -->

##  Additional notes ##
<!-- Include any additional information, caveats, or considerations that
the reviewer should be aware of. -->

***As a contributor to the Anemoi framework, please ensure that your
changes include unit tests, updates to any affected dependencies and
documentation, and have been tested in a parallel setting (i.e., with
multiple GPUs). As a reviewer, you are also responsible for verifying
these aspects and requesting changes if they are not adequately
addressed. For guidelines about those please refer to
https://anemoi.readthedocs.io/en/latest/***

By opening this pull request, I affirm that all authors agree to the
[Contributor License
Agreement.](https://github.com/ecmwf/codex/blob/main/Legal/contributor_license_agreement.md)
Copy link
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR seems to break anemoi-datasets, something to do with the building of the loaders config? Is it because of the changes to the DotDict (which datasets.create.Config inherits from) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ATS approval needed dependencies Pull requests that update a dependency file tests

Projects

Status: To be triaged

Development

Successfully merging this pull request may close these issues.

4 participants