[MOB-3548] Fix vertical spacing in Default Browser Dialog #997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MOB-3548: fix vertical spacing for iPad DefaultBrowserDialog
There was a problem hiding this comment.
Pull request overview
This PR fixes a vertical spacing issue in the Default Browser Dialog that was causing UI problems on iPad. The fix ensures proper spacing is maintained between UI elements by removing a low-priority constraint modifier.
Changes:
- Removed
.priority(.defaultLow)from the actionButton's top anchor constraint to make spacing between triviaView and actionButton a required constraint
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TimNowaczynski
commented
Jan 22, 2026
| triviaView.trailingAnchor.constraint(equalTo: titleLabel.trailingAnchor), | ||
|
|
||
| actionButton.topAnchor.constraint(equalTo: triviaView.bottomAnchor, constant: .ecosia.space._1l).priority(.defaultLow), | ||
| actionButton.topAnchor.constraint(equalTo: triviaView.bottomAnchor, constant: .ecosia.space._1l), |
Author
There was a problem hiding this comment.
Can somebody tell why we added a .priority(...) here in the first place?
Author
|
I just noticed what I broke now. Will fix this tomorrow :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MOB-3548: Default Browser modal UI is broken on iPad
This is how it now looks like on iPad and iPhone: