Skip to content

Allow squizlabs/php_codesniffer ^4.0#299

Merged
TomasVotruba merged 8 commits into
ecsphp:mainfrom
bytehead:feature/codesniffer-4
Oct 31, 2025
Merged

Allow squizlabs/php_codesniffer ^4.0#299
TomasVotruba merged 8 commits into
ecsphp:mainfrom
bytehead:feature/codesniffer-4

Conversation

@bytehead

Copy link
Copy Markdown
Contributor

Comment thread composer.json Outdated
@bytehead

Copy link
Copy Markdown
Contributor Author

@bytehead bytehead marked this pull request as ready for review September 18, 2025 15:35
leofeyer pushed a commit to contao/easy-coding-standard that referenced this pull request Sep 26, 2025
Description
-----------

`squizlabs/php_codesniffer` has been released in version 4.0.0, but is incompatible with `symplify/easy-coding-standard` at the moment.

See ecsphp/ecs#299.

Commits
-------

ed604cb Add conflict with squizlabs/php_codesniffer 4.x versions
@u01jmg3

u01jmg3 commented Oct 29, 2025

Copy link
Copy Markdown
Contributor

When is this earmarked for merging/release?

@TomasVotruba

Copy link
Copy Markdown
Member

Hi, thanks for the ping.

To push this PR forward, we'll need to upgrade related package to CS 4 first: https://github.com/symplify/coding-standard/

Comment thread tests/SniffRunner/Application/FixerTest.php
@TomasVotruba TomasVotruba merged commit fa87f3e into ecsphp:main Oct 31, 2025
6 checks passed
@bytehead bytehead deleted the feature/codesniffer-4 branch October 31, 2025 12:29
@bytehead

Copy link
Copy Markdown
Contributor Author

@TomasVotruba Do you know when the release will follow?

@TomasVotruba

Copy link
Copy Markdown
Member

@bytehead Expect next week, got too much on my plate now.
If won't happen by Nov 10, ping me here

@bytehead

Copy link
Copy Markdown
Contributor Author

Ok, thanks for the info 🙏🏼 No worries and no stress attached! Happy weekend!

@samsonasik samsonasik mentioned this pull request Nov 5, 2025
@samsonasik

Copy link
Copy Markdown
Collaborator

@bytehead I've released easy-coding-standard 13.0.0 for it

https://github.com/easy-coding-standard/easy-coding-standard/releases/tag/13.0.0

@bytehead

bytehead commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

Thank you @samsonasik!

leofeyer pushed a commit to contao/easy-coding-standard that referenced this pull request Nov 7, 2025
Description
-----------

Waiting for ecsphp/ecs#299.

Commits
-------

178d04b Update to v13 of symplify/easy-coding-standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants