feat: Lazy Loading Support #235
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy loading support. Addresses #212
edcarroll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is WIP
This is a first attempt at adding lazy loading support (tracking #212). Currently, you can't import a module without getting a double copy of both
SuiLocalizationServiceandSuiPopupConfig, which is undesirable.Currently, this adds
forRootto all modules, meaning any non-lazy loaded imports must use this syntax. This is a breaking change, hence thev0.10.0target.However, I'm thinking perhaps instead we use nothing for a root module, so everything works as expected for existing code, then add a
forChildmethod, that you can use within a lazy loaded module. This would also stop it from being a breaking change.