fix for #666: network issues for one device impacts data gathering of…#669
Open
marcb-dame wants to merge 1 commit intoedgexfoundry:mainfrom
Open
fix for #666: network issues for one device impacts data gathering of…#669marcb-dame wants to merge 1 commit intoedgexfoundry:mainfrom
marcb-dame wants to merge 1 commit intoedgexfoundry:mainfrom
Conversation
…gathering of all devices
cloudxxx8
requested changes
Oct 31, 2025
sansmoraxz
reviewed
Nov 12, 2025
Comment on lines
+39
to
+42
|
|
||
| d.clientMutex.Lock() | ||
| c, ok := d.clientMap[key] | ||
| d.clientMutex.Unlock() |
Contributor
There was a problem hiding this comment.
Wouldn't it be better to convert this into RWMutex and use RLock here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
network issues for one device impacts data gathering of all devices. Fixes #666
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/device-modbus-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
You need to have a (mock) device with network issue causing timeouts (for example, say 10s timeout). And a second device without network issues which you are gathering data from frequently, say 1s
New Dependency Instructions (If applicable)