refactor: Handle no entities found gracefully in event cleanup#5322
Merged
judehung merged 1 commit intoedgexfoundry:mainfrom Dec 2, 2025
Merged
refactor: Handle no entities found gracefully in event cleanup#5322judehung merged 1 commit intoedgexfoundry:mainfrom
judehung merged 1 commit intoedgexfoundry:mainfrom
Conversation
judehung
reviewed
Nov 28, 2025
Member
judehung
left a comment
judehung
left a comment
There was a problem hiding this comment.
Do you intentionally use semicolon instead of colon in the debug log?
- Change deleteReadingsBySubQuery and deleteEvents to return KindEntityDoesNotExist instead of KindContractInvalid when no rows are found - Include SQL statement in error messages for debugging - Log KindEntityDoesNotExist error at debug level Signed-off-by: FelixTing <felix@iotechsys.com>
FelixTing
force-pushed
the
issue-5319
branch
from
97a0d8c to
795e09b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #5319
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)