Skip to content

ci: Add core-keeper as part of scopes for semantic PR check#5331

Merged
cloudxxx8 merged 2 commits intoedgexfoundry:mainfrom
judehung:add-keeper-scope
Dec 18, 2025
Merged

ci: Add core-keeper as part of scopes for semantic PR check#5331
cloudxxx8 merged 2 commits intoedgexfoundry:mainfrom
judehung:add-keeper-scope

Conversation

@judehung
Copy link
Member

@judehung judehung commented Dec 18, 2025

The core-keeper is missing from the scopes of semantic PR check, add it into the list.

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

The core-keeper is missing from the scopes of semantic PR check, add it into the list.

Signed-off-by: Jude Hung <jude@iotechsys.com>
@sonarqubecloud
Copy link

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 21.17%. Comparing base (dd9e956) to head (559c4c9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5331   +/-   ##
=======================================
  Coverage   21.17%   21.17%           
=======================================
  Files         285      285           
  Lines       20958    20958           
=======================================
  Hits         4438     4438           
  Misses      16167    16167           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@judehung judehung marked this pull request as ready for review December 18, 2025 05:03
@judehung judehung requested a review from cloudxxx8 December 18, 2025 05:03
Signed-off-by: Jude Hung <jude@iotechsys.com>
@judehung judehung requested a review from cloudxxx8 December 18, 2025 05:54
Copy link
Member

@cloudxxx8 cloudxxx8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cloudxxx8 cloudxxx8 merged commit a3ee0de into edgexfoundry:main Dec 18, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants