Skip to content

chore: add DD_SERVICE env variable#168

Merged
nadeemshahzad merged 1 commit intomasterfrom
nadeem/env_var_dd_service
Feb 10, 2025
Merged

chore: add DD_SERVICE env variable#168
nadeemshahzad merged 1 commit intomasterfrom
nadeem/env_var_dd_service

Conversation

@nadeemshahzad
Copy link
Contributor

@nadeemshahzad nadeemshahzad commented Feb 10, 2025 •
edited
Loading

Ticket: https://2u-internal.atlassian.net/browse/DOS-5464

Make sure that the following steps are done before merging:

  • Have a Site Reliability Engineer review the PR if you don't own all of the services impacted.
  • If you are adding any new default values that need to be overridden when this change goes live, update internal repos and add an entry to the top of the CHANGELOG.
  • Performed the appropriate testing.

@nadeemshahzad nadeemshahzad force-pushed the nadeem/env_var_dd_service branch from 2640ea5 to b4bcfd7 Compare February 10, 2025 07:52
@nadeemshahzad nadeemshahzad merged commit 6d9e80b into master Feb 10, 2025
3 checks passed
@nadeemshahzad nadeemshahzad deleted the nadeem/env_var_dd_service branch February 10, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NIXKnight NIXKnight NIXKnight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nadeemshahzad @NIXKnight