Skip to content

Add support for SEQUENCE OF ... DEFAULT#139

Open
rbalik wants to merge 3 commits intoeerimoq:masterfrom
rbalik:sequenceofdefault
Open

Add support for SEQUENCE OF ... DEFAULT#139
rbalik wants to merge 3 commits intoeerimoq:masterfrom
rbalik:sequenceofdefault

Conversation

@rbalik
Copy link

@rbalik rbalik commented Jan 14, 2022

This fixes issue #123 specifically for OCTET STRING types in the SEQUENCE
It's basically bare minimum for my specific application. Hopefully good enough to merge in, but happy to hear any feedback

@eerimoq
Copy link
Owner

eerimoq commented Jan 14, 2022

Please add a test or two.

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.68%. Comparing base (e1ecbac) to head (954cba0).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #139   +/-   ##
=======================================
  Coverage   35.68%   35.68%           
=======================================
  Files           7        7           
  Lines        8446     8446           
=======================================
  Hits         3014     3014           
  Misses       5432     5432           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 95.139% when pulling 954cba0 on rbalik:sequenceofdefault into e1ecbac on eerimoq:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants