Add __array_ufunc__ to ADF for NumPy ufunc dispatch#24
Merged
Conversation
Enables numpy math functions (numpy.sin, numpy.cos, etc.) to dispatch directly to their admath equivalents when called on ADF objects. Also handles arithmetic ufuncs (numpy.multiply, numpy.add, etc.) element-wise to preserve existing numpy array * ADF behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12.
__array_ufunc__toADFso that NumPy math ufuncs (e.g.numpy.sin(x),numpy.exp(x)) dispatch to theiradmathequivalents when called on ADF objects — the issue reported in Add ad.math functions to ADF objects. #12.numpy.multiply,numpy.add, etc.) element-wise using Python-level operators, preserving the pre-existing behaviour ofnumpy_array * adf_scalarreturning an object array with derivative tracking intact.max-public-methodsto 25 in ruff config to accommodate the new dunder method.Test plan
pytest tests/ -v)np.sin(adnumber(1.0))returns an ADF with correct derivativenp.logspace(0, 4, 5) * adnumber(2)returns an object array of ADF values with correct derivatives🤖 Generated with Claude Code