Run track-cluster matching separately for each calorimeter #1906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlprotzman
force-pushed
the
track_cluster_match_config
branch
from
9eb01f5 to
0ea528f
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
tlprotzman
force-pushed
the
track_cluster_match_config
branch
from
0ea528f to
3818632
Compare
ruse-traveler
previously approved these changes
Jul 1, 2025
There was a problem hiding this comment.
Very nice! This is a much appreciated improvement! The diffs for the relevant collections look like I'd expect them to, but I am seeing some diffs for a few collections I'd expect to be unaffected by this PR...
This seems to be similar to what we saw in #1919 ... So maybe the artifacts capybara are using out of date?
|
I just noticed that the EcalEndcapPInsert has been removed between starting this and now (#1852), so I removed its track cluster match factory |
|
@ruse-traveler There are somehow irreproducibilities in B0 calorimetry, and they are not yet understood. |
Ahhhh gotcha! |
minjungkim12
pushed a commit
that referenced
this pull request
Jul 14, 2025
### Briefly, what does this PR introduce? A suggested in #1885, the track-cluster matching should be done separately for each calorimeter. Later algorithms can then manage the merging and splitting of clusters and integration across calorimeters. This also makes it simpler to tune the matching criteria separately for each subsystem. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [X] New feature (issue #1885 ) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [ ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? There is no longer a single TrackClusterMatches collection output, instead is is broken into separate collections for each calorimeter ``` EcalEndcapPTrackClusterMatches EcalEndcapPInsertTrackClusterMatches LFHCALTrackClusterMatches HcalEndcapPInsertClusterMatches EcalBarrelTrackClusterMatches HcalBarrelTrackClusterMatches EcalEndcapNTrackClusterMatches HcalEndcapNTrackClusterMatches ``` ### Does this PR change default behavior? See above --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Dmitry Kalinkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
A suggested in #1885, the track-cluster matching should be done separately for each calorimeter. Later algorithms can then manage the merging and splitting of clusters and integration across calorimeters. This also makes it simpler to tune the matching criteria separately for each subsystem.
What kind of change does this PR introduce?
TrackClusterMatch#1885 )Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
There is no longer a single TrackClusterMatches collection output, instead is is broken into separate collections for each calorimeter
Does this PR change default behavior?
See above