Add thread-safety to Truthiness algorithm statistics tracking #2179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Truthiness algorithm accumulates statistics in mutable member variables from a const
process()method, creating race conditions when called concurrently from multiple threads.Changes
m_event_count: Changed fromuint64_ttostd::atomic<uint64_t>for lock-free atomic operationsm_stats_mutex: Added mutex to protectm_average_truthinessupdates during the online average calculationgetAverageTruthiness()now locks,getEventCount()uses atomic.load()Pattern follows existing thread-safe implementations in the codebase (e.g.,
UniqueIDGenSvc).💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.