Add detailed nHCal geometry version using LFHCAL constructor #905
+1,413
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 layers with 4 cm steel and 0.4 cm scintillator Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Co-authored-by: Wouter Deconinck <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…nto negative-HCal-dev
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/hcal_backward.xml Signed-off-by: lkosarz <[email protected]>
Removed empty environments Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Restored rmin and rmax to the decector parameter table Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
# Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
…HCal-dev # Conflicts: # compact/definitions.xml # compact/hcal/backward.xml Signed-off-by: Kosarzewski <[email protected]>
Changed air gap to 0.5mm = 2*LFHCAL Signed-off-by: Kosarzewski <[email protected]>
Signed-off-by: Kosarzewski <[email protected]>
Co-authored-by: Dmitry Kalinkin <[email protected]>
Need cleanup Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: lkosarz <[email protected]>
Signed-off-by: Kosarzewski <[email protected]>
github-actions
bot
added
topic: backward
for more information, see https://pre-commit.ci
veprbl
reviewed
Jul 10, 2025
Comment on lines
78
to
89
| <documentation> | ||
| ### Forward (Positive Z) Endcap Hadronic Calorimeter | ||
|
|
||
| This is the ECCE LFHCAL design without individual tower placements and electronics | ||
| The original design was 60 layers of Steel/Sc and 10 layers of W/Sc, both 1.6 cm/0.4 cm | ||
| This is too long, so 5 layers of tungsten were removed as a placeholder until the final design is chosen | ||
|
|
||
| The HCal forward insert shape is cut out from this detector | ||
|
|
||
| Currently don't have an implementation of electronics, so just leave that area (final 10 cm) empty | ||
| So then, actual detector area is "nHCal_LFHCAL_length - LFHCALElectronicsThickness" long | ||
| </documentation> |
compact/hcal/backward_LFHCAL_geo.xml
Outdated
Comment on lines
177
to
191
| <!-- <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="4"> | ||
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | ||
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | ||
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | ||
| </layer> | ||
| <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="5"> | ||
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | ||
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | ||
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | ||
| </layer> | ||
| <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="6"> | ||
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | ||
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | ||
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | ||
| </layer>--> |
There was a problem hiding this comment.
Suggested change
| <!-- <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="4"> | |
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | |
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | |
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | |
| </layer> | |
| <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="5"> | |
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | |
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | |
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | |
| </layer> | |
| <layer repeat="LFHCALLayer_NSteelRepeatS" vis="InvisibleWithDaughters" readoutlayer="6"> | |
| <slice material="Polystyrene" thickness="LFHCALPolystyreneThickness" vis="LFHCALLayerScintVis" sensitive="yes" limits="cal_limits" type="3" /> | |
| <slice material="Kapton" thickness="LFHCALKaptonThickness" vis="LFHCALLayerKaptonVis" type="2" offset="LFHCALAirOffset"/> | |
| <slice material="StainlessSteelSAE304" thickness="LFHCALAbsorberThickness" vis="LFHCALLayerSteelVis" type="1"/> | |
| </layer>--> |
Comment on lines
+193
to
+203
| <documentation> | ||
| ### for testing of a single module | ||
| </documentation> | ||
| <!-- <eightmodulepositions name="xpos" unit="cm" values="15 35"/> | ||
| <eightmodulepositions name="ypos" unit="cm" values="15 35"/> --> | ||
| <!-- <eightmodulepositions name="zpos" unit="cm" values="0 0"/> --> | ||
| <!-- <fourmodulepositions name="xpos" unit="cm" values="-25 -35"/> | ||
| <fourmodulepositions name="ypos" unit="cm" values="-25 -35"/> | ||
| <fourmodulepositions name="zpos" unit="cm" values="0 0"/> --> | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| <documentation> | |
| ### for testing of a single module | |
| </documentation> | |
| <!-- <eightmodulepositions name="xpos" unit="cm" values="15 35"/> | |
| <eightmodulepositions name="ypos" unit="cm" values="15 35"/> --> | |
| <!-- <eightmodulepositions name="zpos" unit="cm" values="0 0"/> --> | |
| <!-- <fourmodulepositions name="xpos" unit="cm" values="-25 -35"/> | |
| <fourmodulepositions name="ypos" unit="cm" values="-25 -35"/> | |
| <fourmodulepositions name="zpos" unit="cm" values="0 0"/> --> |
compact/hcal/backward_LFHCAL_geo.xml
Outdated
Comment on lines
3
to
6
| <info name="lfhcal.xml" | ||
| title="EPIC LFHCAL" | ||
| author="@FriederikeBock" | ||
| url="https://github.com/FriederikeBock" |
There was a problem hiding this comment.
Suggested change
| <info name="lfhcal.xml" | |
| title="EPIC LFHCAL" | |
| author="@FriederikeBock" | |
| url="https://github.com/FriederikeBock" | |
| <info name="backward_LFHCAL_geo.xml" | |
| title="EPIC nHcal" | |
| author="@lkosarz" | |
| url="https://github.com/lkosarz" |
compact/hcal/backward_LFHCAL_geo.xml
Outdated
| /> | ||
| <position x="50*cm" y="60*cm" z="nHCal_LFHCAL_length - LFHCALElectronicsThickness" /> | ||
| </fourmodule> | ||
| <layer repeat="LFHCALLayer_NSteelRepeatSFirst" vis="InvisibleWithDaughters" readoutlayer="0"> |
There was a problem hiding this comment.
Are these constructed in order of decreasing
There was a problem hiding this comment.
I'll update this in the next step.
compact/hcal/backward_LFHCAL_geo.xml
Outdated
| <constant name="Mod_PCBWidth" value="70* mm"/> | ||
| <constant name="Mod_PCBThickness" value="4* mm"/> | ||
| <constant name="Mod_PCBLength" value="61.0* cm"/> | ||
| <constant name="Mod_PCBOffset" value="0.28* cm+"/> |
There was a problem hiding this comment.
Suggested change
| <constant name="Mod_PCBOffset" value="0.28* cm+"/> | |
| <constant name="Mod_PCBOffset" value="0.28* cm"/> |
compact/hcal/backward_LFHCAL_geo.xml
Outdated
| <constant name="FourM_OuterHeight" value="10.1* cm"/> | ||
| <constant name="FourM_BackInnerWidth" value="7.0* cm"/> | ||
| <constant name="FourM_BackInnerHeight" value="7.0* cm"/> | ||
| <constant name="FourM_NotchHeight" value="75* mm"/> |
There was a problem hiding this comment.
The constants are not scoped. Once you try to integrate, you'll discover a need to have a namespace. I would suggest to use HcalEndcapN prefix wherever possible and remove references to LFHCAL to avoid confusion.
Updated description Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update # Conflicts: # compact/hcal/backward_LFHCAL_geo.xml
for more information, see https://pre-commit.ci
TODO: invert numbering along z (not necessary for now) Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update
Signed-off-by: lkosarz <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: lkosarz <[email protected]>
…to nHCal-dev-update
Signed-off-by: lkosarz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
Adds a new detailed nHCal geometry implementation using LFHCAL constructor. Small update to the constructor.
Changed the cover plate material from Steel235 to be picked up based on absorber layers
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
Does this PR change default behavior?