draft Curved ob #924
+550
−184
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,82 +1,51 @@ | ||
| Curved OB geometry test | ||
| ----------------------- | ||
|
|
||
| This branch has been created by Sam Henry to test a new outer barrel geometry with curved silicon surface. | ||
|
|
||
| The OB stave structure has replaced the flat silicon surface with a curved surface. The carbon fibre frame has been replaced with a flat layer. The staves are no longer tilted and are positioned alternately at radii separated by 6mm. | ||
|
|
||
| In this test, the curved silicon surface for each stave is modelled as a single module - a segment of a cylinder with a radius of 80mm. In the final version we will include the top and bottom layers of the stave with 4 modules for L3 and 8 for L4. | ||
|
|
||
| This is not yet working - eicrecon does not see the outer barrel hits. | ||
|
|
||
| **Modified files:** | ||
|
|
||
| ```src/BarrelTrackerWithFrame_geo.cpp``` | ||
|
|
||
| ```compact/tracking/silicon_barrel.xml``` | ||
|
|
||
| **Additional files:** | ||
|
|
||
| ```SimpleCurved_silicon_barrel.xml``` - alternative version of silicon_barrel.xml with a simpler curved model where all staves are segments of a single big cylinder. | ||
|
|
||
| ```TestOB.sh``` - script to test the geometry, using ```TestOB.C``` and ```epic_craterlake_tracking_only_cut.xml``` | ||
|
|
||
|
|
||
| The test script runs a simulation shooting 1000 muons through the vertex and silicon barrels. It then runs eicrecon and prints the mean of CentralCKFTrajectories.nMeasurements - i.e. the number the barrels the tracks go through. If everything is well, this should be close to 5. If eicrecon is not seeing the outer barrels, it will be 3 | ||
|
|
||
|
|
||
| **Tests** | ||
|
|
||
| Run tests in eic-shell --version 25.07.0-stable . In the latest version, eicrecon generates errors and the control test fails, presumably due to issues with a new ACTs version. | ||
|
|
||
| Control test with epic-main geometry | ||
| ``` | ||
| source /opt/detector/epic-main/bin/thisepic.sh | ||
| ./TestOB.sh | ||
| ``` | ||
| Mean nMeasurements: 5.02398 | ||
|
|
||
| Test new curved model | ||
| ``` | ||
| source install/bin/thisepic.sh | ||
| ./TestOB.sh | ||
|
|
||
| Mean nMeasurements: 3 | ||
| ``` | ||
| Test simple curved model | ||
| ``` | ||
| cp SimpleCurved_silicon_barrel.xml install/share/epic/compact/tracking/silicon_barrel.xml | ||
| ./TestOB.sh | ||
| ``` | ||
| Mean nMeasurements: 4.947 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,201 @@ | ||
| <!-- SPDX-License-Identifier: LGPL-3.0-or-later --> | ||
| <!-- Copyright (C) 2022 Sylvester Joosten, Wouter Deconinck, Shujie Li --> | ||
|
|
||
| <lccdd> | ||
| <define> | ||
| <comment> | ||
| Main parameters - this is for the more realistic June 2022 design | ||
| </comment> | ||
|
|
||
| <constant name="SiBarrelMod1_rmin" value="SiBarrel1_rmin+1*mm"/> | ||
| <constant name="SiBarrelMod2_rmin" value="SiBarrel2_rmin+1*cm"/> | ||
| <constant name="SiBarrelMod_angle" value="SiBarrel_angle"/> | ||
| <constant name="SiBarrelMod_dz" value="SiBarrel_dz"/> | ||
|
|
||
| <constant name="SiBarrelSensor_thickness" value="40*um"/> | ||
|
|
||
| <constant name="SiBarrelMod1Service_thickness" value="0.15*mm"/> | ||
| <constant name="SiBarrelMod2Service_thickness" value="0.37*mm"/> | ||
| <constant name="SiBarrelMod1Frame_thickness" value="0.06*mm"/> | ||
| <constant name="SiBarrelMod2Frame_thickness" value="0.12*mm"/> | ||
| <constant name="SiBarrelMod1Frame_height" value="0.8*cm"/> | ||
| <constant name="SiBarrelMod2Frame_height" value="0.8*cm"/> | ||
| <constant name="SiBarrelStave1_width" value="4*cm"/> | ||
| <constant name="SiBarrelStave2_width" value="4*cm"/> | ||
|
|
||
| <comment> | ||
| Actual parametrization | ||
| </comment> | ||
|
|
||
| <constant name="SiBarrelMod1_length" value="2 * SiBarrelMod1_rmin / tan(SiBarrelMod_angle) - SiBarrel_dz"/> | ||
| <comment> 84cm=2*42cm is the engineer max </comment> | ||
| <constant name="SiBarrelMod2_length" value="84*cm"/> | ||
|
|
||
| <constant name="SiBarrelLayer1_length" value="SiBarrelMod1_length + 1*um"/> | ||
| <constant name="SiBarrelLayer2_length" value="SiBarrelMod2_length + 1*um"/> | ||
| <constant name="SiBarrelEnvelope_length" value="SiBarrelLayer2_length + 1*um" /> | ||
|
|
||
| <constant name="SiBarrelLayer_thickness" value="3.0*cm"/> | ||
| <constant name="SiBarrelLayer1_rmin" value="SiBarrelMod1_rmin "/> | ||
| <constant name="SiBarrelLayer1_rmax" value="SiBarrelLayer1_rmin + SiBarrelLayer_thickness"/> | ||
| <constant name="SiBarrelLayer2_rmin" value="SiBarrelMod2_rmin "/> | ||
| <constant name="SiBarrelLayer2_rmax" value="SiBarrelLayer2_rmin + SiBarrelLayer_thickness"/> | ||
|
|
||
| <constant name="SiBarrelStaveTilt_angle" value="3.0*degree"/> | ||
| <constant name="SiBarrelStave1_count" value="floor(180.*degree/asin(SiBarrelStave1_width*cos(SiBarrelStaveTilt_angle)/2/SiBarrelMod1_rmin))+2"/> | ||
| <constant name="SiBarrelStave2_count" value="floor(180.*degree/asin(SiBarrelStave2_width*cos(SiBarrelStaveTilt_angle)/2/SiBarrelMod2_rmin))+2"/> | ||
| </define> | ||
|
|
||
| <detectors> | ||
| <documentation level="5"> | ||
| ### Actual detectors | ||
| </documentation> | ||
| <detector | ||
| id="TrackerBarrel_0_ID" | ||
| name="SagittaSiBarrel" | ||
| type="epic_TrackerBarrel" | ||
| readout="SiBarrelHits" | ||
| insideTrackingVolume="true"> | ||
| <type_flags type="DetType_TRACKER + DetType_BARREL"/> | ||
| <dimensions | ||
| rmin="SiBarrelLayer1_rmin" | ||
| rmax="SiBarrelLayer1_rmax" | ||
| length="SiBarrelLayer1_length" /> | ||
| <comment>Silicon Barrel Modules</comment> | ||
| <module name="Module1" vis="TrackerLayerVis"> | ||
| <module_component name="Support" | ||
| material="CarbonFiber" | ||
| vis="TrackerSupportVis" | ||
| width="SiBarrelStave1_width*0.8" | ||
| height="SiBarrelMod1Frame_height" | ||
| length="SiBarrelMod1_length" | ||
| thickness="SiBarrelMod1Frame_thickness" /> | ||
|
|
||
| <module_component name="Service" | ||
| material="Aluminum" | ||
| sensitive="false" | ||
| width="SiBarrelStave1_width*0.8" | ||
| length="SiBarrelMod1_length" | ||
| thickness="SiBarrelMod1Service_thickness" | ||
| vis="TrackerLayerVis"/> | ||
| <module_component name="CurvedSilicon" | ||
| material="Silicon" | ||
| sensitive="true" | ||
| radius="SiBarrelMod1_rmin+6*mm" | ||
| offset="-SiBarrelMod1_rmin" | ||
| phi0="-0.068" phi1="0.068" | ||
| width="SiBarrelStave1_width" | ||
| length="SiBarrelMod1_length" | ||
| thickness="SiBarrelSensor_thickness" | ||
| vis="TrackerLayerVis" /> | ||
| </module> | ||
| <comment> Layers composed of many arrayed modules </comment> | ||
| <layer module="Module1" id="3" vis="TrackerLayerVis"> | ||
| <barrel_envelope | ||
| inner_r="SiBarrelLayer1_rmin-0.5*mm" | ||
| outer_r="SiBarrelLayer1_rmax" | ||
| z_length="SiBarrelLayer1_length" /> | ||
| <layer_material surface="inner" binning="binPhi,binZ" bins0="SiBarrelStave1_count" bins1="100" /> | ||
| <layer_material surface="outer" binning="binPhi,binZ" bins0="SiBarrelStave1_count" bins1="100" /> | ||
| <comment> | ||
| phi0 : Starting phi of first module. | ||
| phi_tilt : Phi tilt of a module. | ||
| rc : Radius of the module center. | ||
| nphi : Number of modules in phi. | ||
| rphi_dr : The delta radius of every other module. | ||
| z0 : Z position of first module in phi. | ||
| nz : Number of modules to place in z. | ||
| dr : Radial displacement parameter, of every other module. | ||
| </comment> | ||
| <rphi_layout phi_tilt="0.0" nphi="46" phi0="0.0" rc="SiBarrelMod1_rmin" dr="0.0 * mm"/> | ||
| <z_layout dr="0.0 * mm" z0="0.0 * mm" nz="1"/> | ||
| </layer> | ||
| </detector> | ||
| <documentation level="5"> | ||
| ### Actual detectors | ||
| </documentation> | ||
| <detector | ||
| id="TrackerBarrel_1_ID" | ||
| name="OuterSiBarrel" | ||
| type="epic_TrackerBarrel" | ||
| readout="SiBarrelHits" | ||
| insideTrackingVolume="true"> | ||
| <type_flags type="DetType_TRACKER + DetType_BARREL"/> | ||
| <dimensions | ||
| rmin="SiBarrelLayer2_rmin" | ||
| rmax="SiBarrelLayer2_rmax" | ||
| length="SiBarrelLayer2_length" /> | ||
| <comment>Silicon Barrel Modules</comment> | ||
| <module name="Module1" vis="TrackerLayerVis"> | ||
| <module_component name="Support" | ||
| material="CarbonFiber" | ||
| sensitive="false" | ||
| width="SiBarrelStave2_width*0.8" | ||
| length="SiBarrelMod2_length" | ||
| thickness="SiBarrelMod2Frame_thickness" | ||
| vis="TrackerLayerVis"/> | ||
| <module_component name="Service" | ||
| material="Aluminum" | ||
| sensitive="false" | ||
| width="SiBarrelStave2_width*0.8" | ||
| length="SiBarrelMod2_length" | ||
| thickness="SiBarrelMod2Service_thickness" | ||
| vis="TrackerLayerVis"/> | ||
| <module_component name="CurvedSilicon" | ||
| material="Silicon" | ||
| sensitive="true" | ||
| radius="SiBarrelMod2_rmin+6*mm" | ||
| offset="-SiBarrelMod2_rmin" | ||
| phi0="-0.044" phi1="0.044" | ||
| width="SiBarrelStave2_width" | ||
| length="SiBarrelMod2_length" | ||
| thickness="SiBarrelSensor_thickness" | ||
| vis="TrackerLayerVis" /> | ||
| </module> | ||
|
|
||
| <comment> Layers composed of many arrayed modules </comment> | ||
| <layer module="Module1" id="4" vis="TrackerLayerVis"> | ||
| <barrel_envelope | ||
| inner_r="SiBarrelLayer2_rmin-1.0*mm" | ||
| outer_r="SiBarrelLayer2_rmax" | ||
| z_length="SiBarrelLayer2_length" /> | ||
| <layer_material surface="inner" binning="binPhi,binZ" bins0="128" bins1="100" /> | ||
| <layer_material surface="outer" binning="binPhi,binZ" bins0="128" bins1="100" /> | ||
| <comment> | ||
| phi0 : Starting phi of first module. | ||
| phi_tilt : Phi tilt of a module. | ||
| rc : Radius of the module center. | ||
| nphi : Number of modules in phi. | ||
| rphi_dr : The delta radius of every other module. | ||
| z0 : Z position of first module in phi. | ||
| nz : Number of modules to place in z. | ||
| dr : Radial displacement parameter, of every other module. | ||
| </comment> | ||
| <rphi_layout phi_tilt="0.0" nphi="70" phi0="0.0" rc="SiBarrelMod2_rmin" dr="0.0 * mm"/> | ||
| <z_layout dr="0.0 * mm" z0="0.0 * mm" nz="1"/> | ||
| </layer> | ||
| </detector> | ||
| </detectors> | ||
|
|
||
| <plugins> | ||
| <plugin name="DD4hep_ParametersPlugin"> | ||
| <argument value="SagittaSiBarrel"/> | ||
| <argument value="layer_pattern: str=SagittaSiBarrel_layer\d"/> | ||
| </plugin> | ||
| <plugin name="DD4hep_ParametersPlugin"> | ||
| <argument value="OuterSiBarrel"/> | ||
| <argument value="layer_pattern: str=OuterSiBarrel_layer\d"/> | ||
| </plugin> | ||
| </plugins> | ||
|
|
||
| <readouts> | ||
| <readout name="SiBarrelHits"> | ||
| <segmentation type="MultiSegmentation" key="layer"> | ||
| <segmentation name="L3" type="CylindricalGridPhiZ" key_value="3" grid_size_phi="0.02*mm/(SiBarrelMod1_rmin+6*mm)" grid_size_z="0.02*mm" radius="SiBarrelMod1_rmin+6*mm" /> | ||
| <segmentation name="L4" type="CylindricalGridPhiZ" key_value="4" grid_size_phi="0.04*mm/(SiBarrelMod2_rmin+6*mm)" grid_size_z="0.04*mm" radius="SiBarrelMod2_rmin+6*mm" /> | ||
| </segmentation> | ||
| <id>system:8,layer:4,module:12,sensor:2,phi:32:-16,z:-16</id> | ||
| </readout> | ||
| </readouts> | ||
|
|
||
| </lccdd> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| void TestOB() { | ||
| TFile* eicFile = new TFile("reconTest.edm4eic.root"); | ||
| TTree* eicTree = (TTree*)eicFile->Get("events"); | ||
| eicTree->Draw("CentralCKFTrajectories.nMeasurements>>nM"); | ||
| auto h0 = (TH1I*)gPad->GetPrimitive("nM"); | ||
| cout << "Mean nMeasurements: " << h0->GetMean() << endl; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| #!/bin/bash | ||
| ddsim --compactFile epic_craterlake_tracking_only_cut.xml --outputFile test.edm4hep.root --numberOfEvents 1000 --enableGun --gun.thetaMin 50*deg --gun.thetaMax 130*deg --gun.distribution eta --gun.particle pi- --gun.momentumMin 10*GeV --gun.momentumMax 10*GeV --gun.multiplicity 1 | ||
| eicrecon -Pnthreads=1 -Pjana:debug_plugin_loading=1 -Ppodio:output_file=reconTest.edm4eic.root -Pdd4hep:xml_files=epic_craterlake_tracking_only_cut.xml -Ppodio:output_collections="MCParticles,CentralCKFTrajectories,CentralCKFTrackParameters,CentralCKFSeededTrackParameters,CentralCKFTruthSeededTrackParameters,CentralTrackVertices,ReconstructedChargedParticles,ReconstructedChargedParticleAssociations" test.edm4hep.root | ||
|
There was a problem hiding this comment. Ah, this is something I was just discussing with @veprbl yesterday. When using the (more later, MSc defense to attend now) There was a problem hiding this comment. Yes. This is the method I have been using to run a simulation with just a few sub-detectors - in this case the silicon and vertex barrels - I take one of the xml files in epic/install/share/epic and cut out the bits I don't want. I assume this (usually) works as the links in these files all use $DETECTOR_PATH, but it feels like a very hacky way to do it and I can see it may not always work. What is the correct way to do it? (Where do these xml files come from anyway? Are they generated automatically by cmake --install?) |
||
| root -b TestOB.C reconTest.edm4eic.root | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you had some questions on the segmentation, essentially the maximum extent in phi and z, divided by the grid size in that dimensions, gives you a maximum number of grid points. That number of grid points should fit within the number of bits specified for that dimensions.
E.g. assuming 360 degrees for phi, and grid_size_phi = 0.02*mm/(27.1*cm+6*mm) = 7.2e-5 rad, that means 4986000 grid points, which corresponds to 22.2 i.e. 23 whole bits. So the 16 bits reserved for this dimension is not sufficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I am still puzzling this out - please bear with me.
For this example, I have:
2pi/7.2e-5 = 87022 = 2^16.4 - so we need 17 bits for phi?
522/0.02 = 26100 = 2^14.7 - so we need 15 bits for z?
What does "phi:32:-16,z:-16" actually mean? Is it 32 bits for phi and whatever-is-left for z (then, if the total is 64 would be 64-8-4-12-2-32 = 6, so clearly not enough, unless it is 64 bits just for phi and z?), or are the 32 bits split between phi and z? Is the -16 an offset to allow for negative numbers? I'm guessing it is 32-16=16 bits for phi and then 64-8-4-12-2-16 = 22 for z?
More questions: are these local or global coordinates? Each stave is only 5-8 degrees wide, so do we need to allow for a maximum of 360 degrees? In the CartesianGridXY setup, I assumed the x and y were local coordinates in the plane of each stave. If the CylindricalGridPhiZ is a global coordinate system, that would explain why my model where each stave is a separate cylinder doesn't work. Presumably I need to define the offset axis for each one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This means that the field phi starts at bit 32, has a width of 16 bits and the value is stored as a signed integer. Then the field z follows, also with a width of 16 bit, and also as a signed integer. Signed makes sense here. For r/phi segmentation it would not make sense. But there really is no difference since the conversion from bits to position works regardless and should give the same position.