Repository navigation
fix: resolve Sage caches from HOME in container jobs - #889
Merged
Merged
Conversation
2 tasks done
marcopellegrinoit
marked this pull request as ready for review
October 5, 2026 07:53
fredrikaverpil
force-pushed
the
fix/container-job-cache-paths
branch
3 times, most recently
from
October 7, 2026 12:58
a0bf604 to
0f8c4b4
Compare
Member
|
This action was originally meant to be kept simple and cover 80% of cases. But for the remaining 20% it might be necessary to set up your own action for caching. However, the more correct handling of home path seems like a nice improvement to me, so let's merge this! 馃殌 On top of @marcopellegrinoit's change from #877, I've addressed the following:
Known/possible limitations, not addressed here:
|
When a job runs in a container, hashFiles() cannot hash the workspace and the hardcoded /home/runner paths sit outside the container's HOME (/github/home). Setup failed on the cache key and tool caches were never saved or restored. Hash go.sum files from a shell step instead, which sees the workspace from inside the container. Resolve KOCACHE and the cache paths from HOME, so the same paths work on hosted runners and in containers. The hash step is skipped when caching is disabled and NUL-delimits paths to handle whitespace. Co-authored-by: Fredrik Averpil <fredrik.averpil@einride.tech>
fredrikaverpil
force-pushed
the
fix/container-job-cache-paths
branch
from
October 7, 2026 13:01
0f8c4b4 to
5a47bc6
Compare
fredrikaverpil
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go.sumfrom the workspace shell instead ofhashFiles('**/go.sum'), which looks under/home/runner/workand fails when the job runs in a container.KOCACHEand theactions/cachepaths at~/$HOME, so they follow/home/runneron a hosted runner and/github/homeinside a container.Testing
container:and confirm setup no longer fails onhashFiles, and that the post-job cache save writes under$HOME.Replaces #877, which was opened from a fork.