[Metricbeat] Bump elastic-agent-system-metrics for zswap and cgroups v2 CPU CFS data#49098
[Metricbeat] Bump elastic-agent-system-metrics for zswap and cgroups v2 CPU CFS data#49098orestisfl wants to merge 23 commits intoelastic:mainfrom
Conversation
🤖 GitHub commentsJust comment with:
|
0eecde1 to
9f78d9a
Compare
Vale Linting ResultsSummary: 1 suggestion found 💡 Suggestions (1)
The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
🔍 Preview links for changed docs |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis pull request adds zswap memory metrics collection to the system memory metricset and introduces cgroupv2 CPU weight metric support to the system.process dataset. Changes include updating the elastic-agent-system-metrics dependency from v0.14.1 to v0.14.3 in go.mod and NOTICE.txt, adding field definitions for zswap compression statistics and debug counters under memory.swap, adding the CPU weight field for cgroup v2 CPU scheduling, updating documentation with the new metric field definitions, and modifying test fixtures to account for the new Linux-specific zswap fields. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/test |
|
|
||
|
|
||
| **`system.process.cgroup.cpu.cfs.weight`** | ||
| : CPU weight for the cgroup (cgroupv2). Used by the CFS scheduler to determine the share of CPU time available to the cgroup. Range is 1 to 10000, default 100. |
There was a problem hiding this comment.
Just a curiosity: I assume this metrics apply to EEVDF as well, now that it has been the default Linux scheduler since v6.6. It just feels a bit weird that we still have cfs in the metric name.
vishaangelova
left a comment
There was a problem hiding this comment.
LGTM, left some small suggestions for your consideration.
| CPU weight for the cgroup (cgroupv2). Used by the CFS | ||
| scheduler to determine the share of CPU time available | ||
| to the cgroup. Range is 1 to 10000, default 100. |
There was a problem hiding this comment.
| CPU weight for the cgroup (cgroupv2). Used by the CFS | |
| scheduler to determine the share of CPU time available | |
| to the cgroup. Range is 1 to 10000, default 100. | |
| CPU weight for the cgroup (cgroupv2). Used by the CFS | |
| scheduler to determine the share of CPU time available | |
| to the cgroup. Valid values range from 1 to 10000. The | |
| default value is 100. |
| - name: zswap | ||
| type: group | ||
| description: > | ||
| zswap compressed swap cache metrics. Available on Linux when zswap is enabled. |
There was a problem hiding this comment.
| zswap compressed swap cache metrics. Available on Linux when zswap is enabled. | |
| Metrics for the zswap compressed swap cache. Available on Linux when zswap is enabled. |
|
@orestisfl we should be able to bump Should we backport this PR? Or you planned to address it differently? |
Proposed commit message
Bumps the elastic-agent-system-metrics dependency to v0.14.3, v0.14.2 also included.
What's Changed
Checklist
I have made corresponding change to the default configuration filesstresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. New features.
cd metricbeat mage buildmetricbeat.test.yml:cat /sys/module/zswap/parameters/enabled):Expected output (values will vary):
{ "compressed": 950353920, "uncompressed": 3813502976 }zswap.debug.*fields (requires debugfs access), grant the binary thecap_dac_read_searchcapability:Then re-run. Expected output with debug fields:
{ "compressed": 950353920, "uncompressed": 3813502976, "debug": { "decompress_fail": 0, "pool_limit_hit": 0, "pool_total_size": 950353920, "reject_alloc_fail": 0, "reject_compress_fail": 0, "reject_compress_poor": 0, "reject_kmemcache_fail": 0, "reject_reclaim_fail": 0, "stored_incompressible_pages": 16779, "stored_pages": 931031, "written_back_pages": 29111 } }cfs.weightappears in process cgroup metrics (requires cgroupsv2):Related issues
system.processdataset should support cgroupv2 CPU metrics #47708