convert libbeat system pprof tests to go#49505
Conversation
🤖 GitHub commentsJust comment with:
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe pull request migrates HTTP pprof endpoint tests from a Python-based system test to Go-based integration tests. The Python system test file is removed, and a new Go integration test file is added with three tests that verify pprof endpoint behavior: testing successful responses on ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment Tip CodeRabbit can use your project's `golangci-lint` configuration to improve the quality of Go code reviews.Add a configuration file to your project to customize how CodeRabbit runs |
orestisfl
left a comment
There was a problem hiding this comment.
Fine to merge as is but all three tests could be merged into one test with 3 subtests and share the same mockbeat process.
Proposed commit message
libbeat/tests/system/test_http_pprof.pyto Go integration tests inlibbeat/tests/integration/pprof_test.golibbeat/tests/integration/http_test.gousing theBeatProcframeworkThe following test cases are preserved 1:1 from the Python originals:
TestHttpPProfIndexGET /debug/pprof/TestHttpPProfCmdlineGET /debug/pprof/cmdlineTestHttpPProfNotFoundGET /debug/pprof/not-existThis will eventually allow us to remove Python from test env.
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
None. Test code
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs