Autodiscover: pass paths through builders instead of global paths#49537
Draft
orestisfl wants to merge 6 commits intoelastic:mainfrom
Draft
Autodiscover: pass paths through builders instead of global paths#49537orestisfl wants to merge 6 commits intoelastic:mainfrom
orestisfl wants to merge 6 commits intoelastic:mainfrom
Conversation
orestisfl
added
bug
Team:Elastic-Agent-Data-Plane
botelastic
bot
added
needs_team
Contributor
🤖 GitHub commentsJust comment with:
|
Pass *paths.Path from NewAutodiscover through BuildProvider and each provider's AutodiscoverBuilder into NewBuilders, replacing the previous nil/global approach. Also fixes a bug where the package name `paths` was passed instead of the `path` parameter variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
stresstest.shscript to run them under stress conditions and race detector to verify their stability../changelog/fragmentsusing the changelog tool.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs