Skip to content

update gosigar to v0.14.4#49553

Open
leehinman wants to merge 4 commits intoelastic:mainfrom
leehinman:update_gosigar
Open

update gosigar to v0.14.4#49553
leehinman wants to merge 4 commits intoelastic:mainfrom
leehinman:update_gosigar

Conversation

@leehinman
Copy link
Contributor

Proposed commit message

update github/elastic/gosigar to v0.14.4

This is done specifically to bring in elastic/gosigar#190, which will allow the filesystem metricset of the metricbeat system module to skip over volumes that don't exist on Windows. Examples would be transient, ejected or ghost volumes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works. Where relevant, I have used the stresstest.sh script to run them under stress conditions and race detector to verify their stability.
  • I have added an entry in ./changelog/fragments using the changelog tool.

Disruptive User Impact

Should provide more robust collection of filesystem metrics on Windows systems.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2026
@github-actions
Copy link
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Contributor

mergify bot commented Mar 18, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @leehinman? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@leehinman leehinman added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch backport-9.3 Automated backport to the 9.3 branch labels Mar 18, 2026
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 18, 2026
@leehinman leehinman marked this pull request as ready for review March 18, 2026 21:33
@leehinman leehinman requested a review from a team as a code owner March 18, 2026 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

leehinman and others added 3 commits March 19, 2026 11:35
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f18daae-82f9-49a7-91fe-8f49b6e404a0

📥 Commits

Reviewing files that changed from the base of the PR and between eff0889 and 80acd26.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (3)
  • NOTICE.txt
  • changelog/fragments/1773868374-update-gosigar-to-v0.14.4.yaml
  • go.mod

📝 Walkthrough

Walkthrough

This pull request updates the github.com/elastic/gosigar dependency from version v0.14.3 to v0.14.4 across the project. The changes include updating the version reference in go.mod, updating the corresponding license information in NOTICE.txt, and adding a changelog fragment that documents this as a bug-fix addressing Windows filesystem metric collection errors for volumes that no longer exist in the metricbeat component.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can enable review details to help with troubleshooting, context usage and more.

Enable the reviews.review_details setting to include review details such as the model used, the time taken for each step and more in the review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.19 Automated backport to the 8.19 branch backport-9.2 Automated backport to the 9.2 branch backport-9.3 Automated backport to the 9.3 branch Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants