Skip to content

Allow default_metric deprecation warning in TSDB ESQL YAML tests#143184

Closed
MattAlp wants to merge 2 commits intoelastic:mainfrom
MattAlp:fix/142964-esql-warning-header
Closed

Allow default_metric deprecation warning in TSDB ESQL YAML tests#143184
MattAlp wants to merge 2 commits intoelastic:mainfrom
MattAlp:fix/142964-esql-warning-header

Conversation

@MattAlp
Copy link
Contributor

@MattAlp MattAlp commented Feb 26, 2026

Summary

  • Allow the default_metric deprecation warning in the affected esql/40_tsdb YAML REST test sections.
  • Apply the warning allowance to both to_aggregate_metric_double with multi_values and TS Command grouping on text field so warnings do not fail otherwise-correct assertions.

Closes: #142964

@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label labels Feb 26, 2026
@MattAlp MattAlp added >test-failure Triaged test failures from CI Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL labels Feb 26, 2026
@elasticsearchmachine elasticsearchmachine added needs:risk Requires assignment of a risk label (low, medium, blocker) and removed needs:triage Requires assignment of a team area label labels Feb 26, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@MattAlp MattAlp added low-risk An open issue or test failure that is a low risk to future releases and removed needs:risk Requires assignment of a risk label (low, medium, blocker) labels Feb 26, 2026
@MattAlp MattAlp requested a review from mouhc1ne February 27, 2026 13:44
@MattAlp MattAlp requested a review from limotova February 27, 2026 20:32
@limotova limotova requested a review from gmarouli February 28, 2026 02:38
@limotova
Copy link
Contributor

Going to defer to @gmarouli on this but I think we want to investigate why this is happening a bit more before muting the warnings entirely (see #143217)

@gmarouli
Copy link
Contributor

gmarouli commented Mar 2, 2026

Thanks @limotova , I agree, I am not sure if this is the right fix. And I cannot reproduce it to verify this.
I have to admit that I expected this warning to be thrown when editing or accessing the mapping and not during an ES|QL query. I have seen other similar failures and I am adding extra logging to be able to debug it further, see #143217, I have unmuted this test there.

If you agree, I think we should wait to collect more data, before deciding if we should proceed with this change.

@MattAlp
Copy link
Contributor Author

MattAlp commented Mar 2, 2026

Ok, let's put this PR on hold in favor of seeing why this warning surfaces

@MattAlp MattAlp marked this pull request as draft March 2, 2026 13:45
@gmarouli
Copy link
Contributor

Theoretically, the root cause of this is fixed by #144040. I will close this PR and monitor the failures.

@gmarouli gmarouli closed this Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL low-risk An open issue or test failure that is a low risk to future releases Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] EsqlClientYamlIT test {p0=esql/40_tsdb/to_aggregate_metric_double with multi_values} failing

5 participants