Aggregate counter downsampling preserves resets#143381
Merged
gmarouli merged 38 commits intoelastic:mainfrom Mar 13, 2026
Merged
Aggregate counter downsampling preserves resets#143381gmarouli merged 38 commits intoelastic:mainfrom
gmarouli merged 38 commits intoelastic:mainfrom
Conversation
gmarouli
commented
Mar 2, 2026
.../qa/rest/src/yamlRestTest/resources/rest-api-spec/test/downsample-with-security/10_basic.yml
Show resolved
Hide resolved
This was referenced Mar 2, 2026
gmarouli
added
>enhancement
:StorageEngine/Downsampling
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Hi @gmarouli, I've created a changelog YAML for you. |
kkrik-es
reviewed
Mar 2, 2026
...ample/qa/mixed-cluster/src/yamlRestTest/resources/rest-api-spec/test/downsample/10_basic.yml
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Mar 2, 2026
...ample/qa/mixed-cluster/src/yamlRestTest/resources/rest-api-spec/test/downsample/10_basic.yml
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Mar 2, 2026
...sample/src/internalClusterTest/java/org/elasticsearch/xpack/downsample/DownsampleRateIT.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Mar 2, 2026
...ugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/CounterResetDataPoints.java
Outdated
Show resolved
Hide resolved
kkrik-es
reviewed
Mar 2, 2026
| private final ExponentialHistogramFieldDownsampler[] exponentialHistogramDownsamplers; | ||
| private final TDigestHistogramFieldDownsampler[] tDigestHistogramDownsamplers; | ||
| private final NumericMetricFieldDownsampler[] numericDownsamplers; | ||
| private final NumericMetricFieldDownsampler.AggregateCounterFieldDownsampler[] aggregateCounterDownsamplers; |
Contributor
There was a problem hiding this comment.
Not a big fan of undocumented variables.. maybe add a quick note of what is this tracking?
Contributor
Author
There was a problem hiding this comment.
Let me know if it's more clear, otherwise I will iterate
kkrik-es
reviewed
Mar 3, 2026
| private long timestamp; | ||
| private int docCount; | ||
| private CounterResetDataPoints counterResetDataPoints; | ||
| private final List<AbstractFieldDownsampler<?>> fieldDownsamplers; |
Contributor
There was a problem hiding this comment.
Nit: it's a bit confusing now, since dimensions and counters are also fields. Let's add comments, or maybe rename the variables to document what each one covers.
Contributor
Author
There was a problem hiding this comment.
I added comments here too.
Contributor
Author
|
Buildkite benchmark this with tsdb please |
martijnvg
reviewed
Mar 10, 2026
...wnsample/src/main/java/org/elasticsearch/xpack/downsample/NumericMetricFieldDownsampler.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Buildkite benchmark this with tsdb please |
Collaborator
💚 Build Succeeded
This build ran two tsdb benchmarks to evaluate performance impact of this PR. History
|
Contributor
Author
|
Aggregate Last value |
martijnvg
approved these changes
Mar 11, 2026
...lugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/TimestampValueFetcher.java
Outdated
Show resolved
Hide resolved
...ugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DownsampleShardIndexer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Martijn van Groningen <martijn.v.groningen@gmail.com>
Contributor
Author
|
Aggregate Last value |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we aim to improve the accuracy of the aggregate counter by the following changes:
Our hypothesis is that with these two changes, we can have a more accurate counter estimation without a big performance regression (vefiried in #142280), assuming that reset events are rare and usually affect all counters at the same moment.
Closes #136178