Move resolve aliases to IndexAbstractionOptions#143953
Open
jfreden wants to merge 4 commits intoelastic:mainfrom
Open
Move resolve aliases to IndexAbstractionOptions#143953jfreden wants to merge 4 commits intoelastic:mainfrom
jfreden wants to merge 4 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 11, 2026
There has been several discussions on this topic since I opened #141050 and @idegtiarenko also mentioned this in #143561 (comment). The issue is that both `resolveViews` and `resolveAliases` are in `WildcardOptions` but are used when resolving both concrete index pattern targets and wildcard targets. This PR moves `resolveViews` from `IndicesOptions.WildcardOptions` into a new `IndicesOptions.IndexAbstractionOptions` record to address this confusing inconsistency. This is in preparation for sending `resolveViews` as a parameter to field caps for remote view resolving where more work will be done to serialize `resolveViews` and not having this in place would make for confusing code. See #143384 for more information on the upcoming serialization of `resolveViews`. **_Note_**: `resolveAliases` is moved in a follow up PR since it's decoupled from the resolveViews changes. #143953 **_Note_**: `IndicesRequest.includeDataStreams()` is the same type of flag as `resolveAliases` and `resolveViews`, it controls whether data streams participate in index resolution. It's a candidate for `IndexAbstractionOptions` but currently lives on `IndicesRequest` (not `IndicesOptions`) and is threaded separately through `IndexNameExpressionResolver.Context` as a constructor parameter. Moving it would touch 60+ files and change the `IndicesRequest` interface. Because of how big that change would be, I have not considered doing that in this PR (or at all).
jfreden
force-pushed
the
move_resolve_aliases
branch
from
6010006 to
015e98e
Compare
jfreden
force-pushed
the
move_resolve_aliases
branch
from
30caf92 to
1402f33
Compare
elasticsearchmachine
added
the
serverless-linked
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
|
|
||
| public static Builder builder(IndexAbstractionOptions indexAbstractionOptions) { | ||
| return new Builder(indexAbstractionOptions); | ||
| } |
Contributor
There was a problem hiding this comment.
NIT: we have 2 static builder methods today: one for starting from scratch and one to start editing other abstraction. I wonder if we should change it to be instance method:
IndicesOptions.builder(options.indexAbstractionOptions())...build() -> options.indexAbstractionOptions().builder()...build().
It is different from existing approach but it looks a bit cleaner to me.
Contributor
Author
There was a problem hiding this comment.
I agree that is a lot nicer, but the other IndicesOptions are using that style of builder so I think it would be inconsistent and require a full refactor of all of them, which I think is out of scope for this PR.
Contributor
There was a problem hiding this comment.
I agree, this is not blocking this PR
idegtiarenko
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up from #143741 to also move resolve aliases to
IndexAbstractionOptions.