[Alerting v2] Export composable page components from public start contract by dominiqueclarke · Pull Request #288805 · elastic/kibana

dominiqueclarke · 2026-09-02T19:30:11Z

Summary

Closes elastic/rna-program#1019

Exports five DI-wrapped page components from AlertingV2PublicStart so solution plugins (e.g. Observability Alerting) can mount alerting v2 surfaces at their own routes without duplicating provider setup.

New exports on `AlertingV2PublicStart`

Component	Surface
`RulesPage`	Rules list, rule detail, sequence builder
`RuleLibraryPage`	Rule library / templates
`EpisodesPage`	Alerts inbox, alert detail
`ActionPoliciesPage`	Action policies CRUD
`ExecutionHistoryPage`	Execution history

Props

interface AlertingV2PageProps {
  coreStart: CoreStart;
  setBreadcrumbs: (crumbs: ChromeBreadcrumb[]) => void;
}

Each component internally resolves the Inversify DI container from coreStart.injection.getContainer(), creates a fresh QueryClient, and wraps the corresponding *App in the full provider stack (Context.Provider, QueryClientProvider, BreadcrumbProvider, I18nProvider). EpisodesPage additionally assembles the KibanaContextProvider service bag and RedirectAppLinks.

Consumer usage

const { RulesPage } = alertingVTwoStart;

<Route path="/rules/v2">
  <RulesPage coreStart={coreStart} setBreadcrumbs={setBreadcrumbs} />
</Route>

Files changed

public/application/composable_pages.tsx — new, the five wrapped components
public/application/composable_pages.test.tsx — new, 11 tests
public/types.ts — add page types + AlertingV2PageProps to start contract
public/index.ts — lazy-load composable pages, wire into start binding

Test plan

All 11 composable page tests pass
Verify alerting v2 management apps still work (unaffected — mount.tsx unchanged)
Consumer integration test: mount a composable page from another plugin's app shell

Made with Cursor

…ublic start contract Adds five lazy-loaded page components (RulesPage, RuleLibraryPage, EpisodesPage, ActionPoliciesPage, ExecutionHistoryPage) to AlertingV2PublicStart so solution plugins can mount alerting v2 surfaces at their own routes without duplicating the DI container, QueryClient, breadcrumb, and i18n provider setup. Each component accepts { coreStart, setBreadcrumbs } and internally resolves the Inversify container, creates a fresh QueryClient, and wraps the corresponding *App component in the full provider stack. EpisodesPage additionally assembles the KibanaContextProvider service bag from the DI container, matching the management mount behavior. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions

Reviewed the composable page exports. The five wrapped components faithfully mirror the existing mount.tsx provider stack (all episode dependencies are requiredPlugins, so the DI container.get calls are safe, and the module is correctly code-split via React.lazy). One inline note on stabilizing the EpisodesPage services bag to avoid unnecessary context re-renders.

Generated by Claude Reviewer for #288805 · opus · 153.1 AIC · ⌖ 14.2 AIC · ⊞ 5.1K

…outer, tab href overrides, and execution history tab rename Fixes discovered during the IA demo: - Inject the alerting v2 DI container via module-level closure instead of coreStart.injection.getContainer() (wrong container scope for cross-plugin consumers) - Wrap each composable page in MemoryRouter so inner *App routes see / as root - Add EuiPageSection paddingSize="m" for management-parity layout - Add TabHrefOverrides context so v1/v2 Rules tab hrefs can be overridden by solution plugins (observability alerting URLs instead of management) - Wire tabs into RulesListHeader via useTabHrefOverrides - Rename execution history "Policies" tab to "Action Policies" - Update tests for new container prop and internal MemoryRouter Co-authored-by: Cursor <cursoragent@cursor.com>

…elated changes Memoize kibanaReactServices in AlertingV2EpisodesPage with useMemo keyed on coreStart/container and hoist Storage to module scope to prevent unnecessary KibanaContextProvider re-renders. Revert rules_list_header tab-wiring and execution_history label rename that depend on packages not yet on main. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions

Reviewed the new tabHrefOverrides prop and the reworked container/lazy wiring. One inline note on the shared page props advertising tabHrefOverrides on all five exported pages while only RulesPage honors it. The earlier EpisodesPage services-bag memoization concern is now addressed (useMemo + hoisted Storage); requesting resolution of that thread.

Generated by Claude Reviewer for #288805 · opus · 123 AIC · ⌖ 14.4 AIC · ⊞ 5.1K

Tab href overrides will be introduced in a separate PR; keep this change focused on the base composable page exports. Co-authored-by: Cursor <cursoragent@cursor.com>

…t interface Co-authored-by: Cursor <cursoragent@cursor.com>

baileycash-elastic · 2026-09-03T16:42:05Z

+        <QueryClientProvider client={queryClient}>
+          <BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>
+            <I18nProvider>
+              <MemoryRouter>


shouldn't the consumers be the ones to handle all navigation/routing?

baileycash-elastic · 2026-09-03T16:50:30Z

+    React.createElement(
+      React.Suspense,
+      { fallback: null },
+      React.createElement(LazyComponent, { ...props, container: _alertingV2Container! })


can't you just use the container from props?

Suggested change

React.createElement(LazyComponent, { ...props, container: _alertingV2Container! })

React.createElement(LazyComponent, { ...props, container: props.coreStart.injection.getContainer() })

…I container from props Consumers must provide their own Router ancestor, removing the internal MemoryRouter that fought with the consumer's router context. The module-scoped _alertingV2Container is replaced by props.coreStart.injection.getContainer() per review feedback. Also drops the deprecated RedirectAppLinks wrapper. Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions

Reviewed the composable page exports. The five wrapped pages otherwise faithfully mirror the mount.tsx provider stacks; the earlier memoization and tabHrefOverrides concerns are resolved. One inline note on EpisodesPage dropping the episodes-specific RedirectAppLinks wrapper.

Generated by Claude Reviewer for #288805 · opus · 170.2 AIC · ⌖ 14.4 AIC · ⊞ 5.1K

github-actions · 2026-09-03T20:04:11Z

+    <KibanaContextProvider services={kibanaReactServices}>
+      <Context.Provider value={container}>
+        <QueryClientProvider client={queryClient}>
+          <BreadcrumbProvider setBreadcrumbs={setBreadcrumbs}>


mountEpisodesApp in mount.tsx wraps <EpisodesApp /> in <RedirectAppLinks coreStart={coreStart}>, but this composable version omits it (the import is also gone, though the test still mocks @kbn/shared-ux-link-redirect-app). None of the other four pages had RedirectAppLinks in mount.tsx — it was episodes-specific — so a consumer can't be assumed to supply it globally. Without it, cross-app anchor links rendered inside the episodes/alert-detail UI (e.g. Discover, doc-viewer links) fall back to full page reloads instead of SPA navigation, a user-visible regression versus the management episodes app. The PR description states EpisodesPage "additionally assembles ... and RedirectAppLinks", which suggests this drop was unintentional. Re-add the wrapper (and its import) around <EpisodesApp />.

I'm gonna leave out of this PR for now, the redirect and the router stuff is tricky and I need to be able to use it in a consumer to know exactly what I need.

davismcphee

Code-only review, Data Discovery changes LGTM 👍 Just an updated mock.

davismcphee · 2026-09-03T21:28:34Z

+      services.alertingVTwo = {
+        CreateRuleOptionsFlyout: createRuleOptionsFlyoutMock,
+        RulesPage: jest.fn(() => null),
+        RuleLibraryPage: jest.fn(() => null),
+        EpisodesPage: jest.fn(() => null),
+        ActionPoliciesPage: jest.fn(() => null),
+        ExecutionHistoryPage: jest.fn(() => null),
+      };


Nit: long term, it would be better to instead update the shared services mock directly:

kibana/src/platform/plugins/shared/discover/public/__mocks__/services.ts

Lines 334 to 336 in dd0fca8

alertingVTwo: {

CreateRuleOptionsFlyout: jest.fn(() => null),

},

Not a blocker or anything though.

kibanamachine · 2026-09-06T03:33:52Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: d14def6
Build duration: 58 mins
Storybooks Preview

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`shared-packages`	1256	1264	+8
`shared-plugins`	3836	3849	+13
total			+21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`alertingVTwo`	577.2KB	826.7KB	⚠️ +249.5KB
`workflowsManagement`	1.5MB	1.5MB	-34.6KB
total			+214.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`alertingVTwo`	18.8KB	19.9KB	+1.1KB
`shared-packages`	4.5MB	4.6MB	+50.2KB
`shared-plugins`	11.9MB	12.0MB	+41.8KB
total			+93.1KB

Unknown metric groups

async chunk count

id	before	after	diff
`alertingVTwo`	26	27	+1

shared chunks total size

id	before	after	diff
`all`	7.0MB	6.9MB	-37.5KB

total optimizer output size

id	before	after	diff
`all`	63.2MB	63.5MB	⚠️ +270.6KB

Test Failures

[job] [logs] Jest Tests #1 / GraphGroupedNodePreviewPanel Pagination Behavior Page Size Changes should reset pageIndex to 0 when changing pageSize to 25
[job] [logs] FTR Configs #84 / lens app - group 2 lens datatable should allow toggling row numbers from the style settings flyout
[job] [logs] FTR Configs #64 / serverless search UI - search features Console Notebooks has notebooks view available

History

💔 Build #497273 failed 7d1864d
💛 Build #496544 was flaky b083163
💛 Build #496426 was flaky 2892585
💔 Build #496358 failed 5c7e7bf
💔 Build #496268 failed 18bdc2b

github-actions Bot added the author:actionable-obs PRs authored by the actionable obs team label Sep 2, 2026

dominiqueclarke added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.6.0 labels Sep 2, 2026

dominiqueclarke marked this pull request as ready for review September 2, 2026 19:42

dominiqueclarke requested a review from a team as a code owner September 2, 2026 19:42

github-actions Bot reviewed Sep 2, 2026

View reviewed changes

Comment thread x-pack/platform/plugins/shared/alerting_v2/public/application/composable_pages.tsx Outdated

kibanamachine and others added 4 commits September 2, 2026 19:54

Changes from node scripts/eslint_all_files --no-cache --fix

f59596f

adjust composable pages

18bdc2b

github-actions Bot reviewed Sep 3, 2026

View reviewed changes

Comment thread x-pack/platform/plugins/shared/alerting_v2/public/application/composable_pages.tsx Outdated

dominiqueclarke and others added 2 commits September 3, 2026 11:51

Remove tab href override plumbing from composable pages

3e87700

Tab href overrides will be introduced in a separate PR; keep this change focused on the base composable page exports. Co-authored-by: Cursor <cursoragent@cursor.com>

Fix Discover get_alerts test to satisfy expanded AlertingV2PublicStar…

2892585

…t interface Co-authored-by: Cursor <cursoragent@cursor.com>

dominiqueclarke requested a review from a team as a code owner September 3, 2026 16:09

baileycash-elastic reviewed Sep 3, 2026

View reviewed changes

github-actions Bot reviewed Sep 3, 2026

View reviewed changes

davismcphee approved these changes Sep 3, 2026

View reviewed changes

baileycash-elastic approved these changes Sep 4, 2026

View reviewed changes

dominiqueclarke enabled auto-merge (squash) September 4, 2026 23:01

dominiqueclarke added 2 commits September 4, 2026 19:01

Merge branch 'main' into alerting-v2/export-composable-pages

7d1864d

Merge branch 'main' into alerting-v2/export-composable-pages

d14def6

dominiqueclarke merged commit d824967 into elastic:main Sep 6, 2026
41 checks passed

	React.createElement(LazyComponent, { ...props, container: _alertingV2Container! })
	React.createElement(LazyComponent, { ...props, container: props.coreStart.injection.getContainer() })

	alertingVTwo: {
	CreateRuleOptionsFlyout: jest.fn(() => null),
	},

Uh oh!

Conversation

dominiqueclarke commented Sep 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

New exports on AlertingV2PublicStart

Props

Consumer usage

Files changed

Test plan

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

baileycash-elastic Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

baileycash-elastic Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

dominiqueclarke Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

davismcphee Sep 3, 2026

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Sep 6, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

Page load bundle

async chunk count

shared chunks total size

total optimizer output size

Test Failures

History

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dominiqueclarke commented Sep 2, 2026 •

edited

Loading

New exports on `AlertingV2PublicStart`