Skip to content

[Nightshift][Investigations] Rank investigation recommendations and blind spots by confidence - #289743

Merged
mykolaharmash merged 4 commits into
elastic:mainfrom
mykolaharmash:rank-investigation-output-by-confidence
Sep 11, 2026
Merged

[Nightshift][Investigations] Rank investigation recommendations and blind spots by confidence#289743
mykolaharmash merged 4 commits into
elastic:mainfrom
mykolaharmash:rank-investigation-output-by-confidence

Conversation

@mykolaharmash

@mykolaharmash mykolaharmash commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Closes https://github.com/elastic/nightshift-program/issues/1328

Depends on #289984.

Require investigation recommendations and blind spots to carry relevance confidence, rank them by that confidence, and retain only the three strongest items. Output that does not satisfy the current investigation state schema is ignored (explicitly ignoring old investigation results).

Notable changes

  • Uses one strict investigation state schema that requires bounded confidence and stably sorts recommendation and blind-spot lists.
  • Applies the same schema to live progress, persistence updates, and reads; legacy unscored arrays are omitted.
  • Displays each recommendation's confidence as a percentage in the Nightshift flyout.

@mykolaharmash
mykolaharmash force-pushed the rank-investigation-output-by-confidence branch 3 times, most recently from 700617b to a1ef2a2 Compare September 9, 2026 09:19
@mykolaharmash
mykolaharmash marked this pull request as ready for review September 9, 2026 09:51
@mykolaharmash
mykolaharmash requested review from a team as code owners September 9, 2026 09:51
@kibanamachine kibanamachine added the reviewer:scout Agentic PR Scout test review label Sep 9, 2026
@elastic-vault-github-plugin-prod
elastic-vault-github-plugin-prod Bot requested a review from a team as a code owner September 9, 2026 10:04
@botelastic botelastic Bot added the Team:One Workflow Team label for One Workflow (Workflow automation) label Sep 9, 2026
@mykolaharmash mykolaharmash added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Sep 9, 2026
@mykolaharmash
mykolaharmash force-pushed the rank-investigation-output-by-confidence branch from dc81aea to 5eb04bd Compare September 9, 2026 14:29
@mykolaharmash mykolaharmash changed the title Rank investigation recommendations and blind spots by confidence [Nightshift][Investigations] Rank investigation recommendations and blind spots by confidence Sep 9, 2026
@kibanamachine

Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
nightshift 110.5KB 110.4KB -20.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
shared-packages 4.6MB 4.6MB +135.0B
Unknown metric groups

total optimizer output size

id before after diff
all 63.7MB 63.7MB +115.0B

warm start memory

id before after diff
post forced gc heap baseline - 833397674 +833397674
post forced gc heap delta - -1815724 -1815724
post forced gc heap delta standard deviation - 1319682 +1319682
post forced gc heap target - 831581950 +831581950
tail heap delta - 132173 +132173
total +1664615755

Test Failures

  • [job] [logs] Scout Lane #3 - stateful-classic / default / local-stateful-classic - Discover tabs - tab preview - should preserve content after refresh
  • [job] [logs] Scout Lane #3 - stateful-classic / default / local-stateful-classic - Discover tabs - time range - should save different time ranges when the switch is on

History

Comment on lines +284 to +286
situation". Score how strongly the findings support that each action will help, sort
by confidence descending, and return only the 3 strongest items.
maxItems: 3

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a philosophical question at this point, but is a hard limit going to cause problems for LLM work? I am imagining an outage where 4+ services need to be restarted, the LLM splits them into one action per service -- but has to choose the 3 strongest, so leaves off a critical action. Hopefully we can account for this with other prompt instructions.

@jasonrhodes jasonrhodes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge and iterate after we see how it performs on some real data

@mykolaharmash
mykolaharmash merged commit ac8fd5c into elastic:main Sep 11, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes reviewer:scout Agentic PR Scout test review Team:One Workflow Team label for One Workflow (Workflow automation) v9.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants