Skip to content

Add AppMenu scout helpers - #290449

Open
kowalczyk-krzysztof wants to merge 3 commits into
elastic:mainfrom
kowalczyk-krzysztof:feat/scout-app-menu
Open

Add AppMenu scout helpers#290449
kowalczyk-krzysztof wants to merge 3 commits into
elastic:mainfrom
kowalczyk-krzysztof:feat/scout-app-menu

Conversation

@kowalczyk-krzysztof

Copy link
Copy Markdown
Member

Summary

This PR adds AppMenu scout helpers and replaces current per-app usages. This does not fix the branching logic - it has to be done individually in each tests by knowing the exact state the button is going to be in, either collapsed into app menu or visible.

@kowalczyk-krzysztof kowalczyk-krzysztof self-assigned this Sep 11, 2026
@kowalczyk-krzysztof kowalczyk-krzysztof added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// labels Sep 11, 2026
@infra-vault-gh-plugin-prod

infra-vault-gh-plugin-prod Bot commented Sep 11, 2026

Copy link
Copy Markdown
🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!
  • Click to trigger kibana-entity-store-performance-from-pr for this PR!
  • Click to trigger kibana-storybooks-from-pr for this PR!

@kibanamachine

Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Unknown metric groups

warm start memory

id before after diff
post forced gc heap baseline - 836316850 +836316850
post forced gc heap delta - -1414414 -1414414
post forced gc heap delta standard deviation - 2004691 +2004691
post forced gc heap target - 834902436 +834902436
tail heap delta - -28971135 -28971135
total +1642838428

Test Failures

  • [job] [logs] Scout Lane #2 - stateful-classic / default / local-stateful-classic - Discover tabs - tab preview - should show the correct content
  • [job] [logs] Scout Lane #2 - stateful-classic / default / local-stateful-classic - Discover tabs - time range - should save different time ranges when the switch is on
  • [job] [logs] Scout Lane #2 - stateful-classic / default / local-stateful-classic - Discover tabs - unsaved local state - locally persists unsaved tab state after refresh

History

cc @kowalczyk-krzysztof

@kowalczyk-krzysztof
kowalczyk-krzysztof marked this pull request as ready for review September 11, 2026 08:59
@kowalczyk-krzysztof
kowalczyk-krzysztof requested review from a team as code owners September 11, 2026 08:59
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/appex-sharedux (Team:SharedUX)

@kibanamachine kibanamachine added the reviewer:scout Agentic PR Scout test review label Sep 11, 2026

@Dosant Dosant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@botelastic botelastic Bot added Team:One Workflow Team label for One Workflow (Workflow automation) Team:streams-ui Streams UI team labels Sep 11, 2026
@infra-vault-gh-plugin-prod

Copy link
Copy Markdown

Pinging @elastic/streams-ui (Team:streams-ui)

@js-jankisalvi js-jankisalvi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

response ops changes lgtm 👍

@markov00 markov00 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visualization changes LGTM

@kowalczyk-krzysztof
kowalczyk-krzysztof removed the request for review from mgadewoll September 11, 2026 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes reviewer:scout Agentic PR Scout test review Team:One Workflow Team label for One Workflow (Workflow automation) Team:SharedUX Platform AppEx-SharedUX (formerly Global Experience) t// Team:streams-ui Streams UI team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants