[Flaky Test Handling] Drop scout from the report-flaky-tests pipeline name - #290465
[Flaky Test Handling] Drop scout from the report-flaky-tests pipeline name#290465csr wants to merge 2 commits into
report-flaky-tests pipeline name#290465Conversation
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
report-flaky-tests pipeline name
…-tests pipeline files
There was a problem hiding this comment.
One non-blocking note on the CODEOWNERS change: a new ownership entry references a Buildkite step script that doesn't exist in the repo yet. The pipeline/script/resource renames themselves are consistent — file paths, the pipeline slug, pipeline_file, sparse-checkout paths, and the locations.yml link are all updated together, and the renamed shell script has no lingering references to the old names.
Generated by Claude Reviewer for #290465 · claude · opus · 221.6 AIC · ⌖ 25.9 AIC · ⊞ 5.5K
| /.buildkite/pipeline-resource-definitions/kibana-report-flaky-tests.yml @elastic/appex-qa @elastic/kibana-operations | ||
| /.buildkite/pipelines/report_flaky_tests.yml @elastic/appex-qa @elastic/kibana-operations | ||
| /.buildkite/scripts/steps/report_flaky_tests.sh @elastic/appex-qa @elastic/kibana-operations | ||
| /.buildkite/scripts/steps/check_flaky_test_issues.sh @elastic/appex-qa @elastic/kibana-operations |
There was a problem hiding this comment.
This ownership entry points to a path that doesn't exist in the repo yet. Unlike the three entries above it (which map to files renamed in this PR), .buildkite/scripts/steps/check_flaky_test_issues.sh is present neither on main nor at this PR's head. The description attributes it to #290095, but that PR is still open (unmerged) and adds the node scripts/check_flaky_test_issues CLI — not this Buildkite step — so the rule is inert and matches nothing until a future PR adds the script.
Not CI-breaking (the CODEOWNERS check regenerates the file and verifies teams; both teams are valid), but the entry is dead until the file lands, and it will silently rot if the eventual script is named or located differently. Consider adding this line in the PR that actually introduces the file, or confirm the final path before landing it here.
There was a problem hiding this comment.
This is correct - I will merge this PR after #290095 (which contains the new file) is in.
💚 Build Succeeded
Metrics [docs]Unknown metric groupswarm start memory
cc @csr |
Summary
Removes
scoutfrom the name of thereport-flaky-testspipeline added in #289870. The report covers flaky tests from every framework (Scout, Jest, FTR, Cypress), so the name gave the wrong impression.kibana / scout / report-flaky-tests→kibana / report-flaky-tests(slugkibana-report-flaky-tests).buildkite/pipeline-resource-definitions/kibana-scout-report-flaky-tests.yml→kibana-report-flaky-tests.yml.buildkite/pipelines/scout_report_flaky_tests.yml→report_flaky_tests.yml.buildkite/scripts/steps/scout_report_flaky_tests.sh→report_flaky_tests.sh.github/CODEOWNERS:@elastic/appex-qa @elastic/kibana-operationsown these files (andcheck_flaky_test_issues.sh, the second step added in [Flaky Test Handling] Addcheck_flaky_test_issuesCLI to find existingfailed-testissues for flaky suites #290095), so either team can approve pipeline changes