Tests performed for the fetch_consumption method #8462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIKTORVAV99
requested changes
Oct 31, 2025
Member
VIKTORVAV99
left a comment
VIKTORVAV99
left a comment
There was a problem hiding this comment.
Thanks for the PR but I fail to understand what you are actually trying to test since you are creating a class of ZoneKey instead of using the ZoneKey type.
Comment on lines
+12
to
+18
| class ZoneKey: | ||
| def __init__(self, zone): self.zone = zone | ||
| def __eq__(self, other): | ||
| if isinstance(other, ZoneKey): return self.zone == other.zone | ||
| return self.zone == other | ||
| def __hash__(self): return hash(self.zone) | ||
| def __str__(self): return self.zone |
Member
There was a problem hiding this comment.
Why is this a class?
ZoneKey is just a type alias of str to help with type flows.
Comment on lines
+29
to
+38
| def mock_dependencies(mocker): | ||
|
|
||
| mocker.patch(f"{PATCH_PATH}.datetime", mocker.MagicMock(wraps=datetime)) | ||
| mocker.patch(f"{PATCH_PATH}.datetime.now", return_value=MOCKED_NOW) | ||
| mocker.patch(f"{PATCH_PATH}.timedelta", timedelta) | ||
|
|
||
| mocker.patch(f"{PATCH_PATH}.fetch_live_consumption", autospec=True) | ||
| mocker.patch(f"{PATCH_PATH}.fetch_historical_consumption", autospec=True) | ||
|
|
||
| mocker.patch(f"{PATCH_PATH}.Session") |
Member
There was a problem hiding this comment.
Dependencies should not be mocked.
| mocker.patch(f"{PATCH_PATH}.Session") | ||
|
|
||
| def test_ct1_live_data_valida(mocker): | ||
| expected_data = [{"time": "now"}] |
Member
There was a problem hiding this comment.
What is this supposed to test?
We don't have any data in this format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I am a beginner in software testing development and I'm trying to contribute to this project. While analyzing the fetch_consumption method, which is located in /electricitymap/contrib/parsers/VN.py, I noticed that the logical operator 'is' should be changed to the logical operator '==', so I modified the VN.py file. I added a test file named test_VN.py in electricitymap/contrib/parsers/tests which tests the method after changing the logical operators. If this is a mistake, I apologize.