Skip to content

Conversation

@Velin92
Copy link
Member

@Velin92 Velin92 commented Nov 12, 2025

fixes #4682

Requires the following PR to be merged: matrix-org/matrix-rust-sdk#5857

@Velin92 Velin92 requested a review from a team as a code owner November 12, 2025 15:26
@Velin92 Velin92 requested review from stefanceriu and removed request for a team November 12, 2025 15:26
@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Nov 12, 2025
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about naming, looks great otherwise 👍

@codecov
Copy link

codecov bot commented Nov 13, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
897 2 895 0
View the full list of 2 ❄️ flaky test(s)
ElementCallServiceTests::testLifetimeIsCapped()

Flake rate in main: 100.00% (Passed 0 times, Failed 1 times)

Stack Traces | 60s run time
Test exceeded execution time allowance of 1 minute
UserSessionFlowCoordinatorTests::testShareMediaRouteWithRoom()

Flake rate in main: 40.00% (Passed 84 times, Failed 56 times)

Stack Traces | 2.94s run time
XCTAssertTrue failed (UnitTests/Sources/UserSessionFlowCoordinatorTests.swift:133)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@Velin92 Velin92 force-pushed the mauroromito/manage_space_children_permissions branch from e8f3bee to 84b981c Compare November 13, 2025 09:59
@sonarqubecloud
Copy link

@Velin92 Velin92 merged commit f32921c into develop Nov 13, 2025
6 of 8 checks passed
@Velin92 Velin92 deleted the mauroromito/manage_space_children_permissions branch November 13, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-wip for anything that isn't ready to ship and will be enabled at a later date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task] Update the Roles and Permissions flow (and screens) to work with Spaces.

3 participants