Skip to content

Conversation

@xuhuifan
Copy link

Summary:

Hi Henri,
Is this version works for you? I will add more test file to it soon.
Xuhui

Please make sure

  • You have updated the CHANGELOG.rst
  • You have updated the documentation (if applicable)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@vuolleko
Copy link
Member

Thanks Xuhui, looks pretty nice already! I'll have a closer look once you add some tests.

Also, the CopulaABC_Sample class is missing.

@wleoncio
Copy link
Contributor

Hi @xuhuifan, any news on the test file? The sooner we get one, the sooner we can add your contribution to the package.

Copy link
Contributor

@wleoncio wleoncio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing test file and CopulaABC_Sample class.

@wleoncio
Copy link
Contributor

@vuolleko, @hpesonen, should I close this due to inactivity? Trying to cleanup a bit, here. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants