Pass request_headers and max_workers in recursive sitemap_to_df calls#411
Open
danishashko wants to merge 1 commit intoeliasdabbas:masterfrom
Open
Pass request_headers and max_workers in recursive sitemap_to_df calls#411danishashko wants to merge 1 commit intoeliasdabbas:masterfrom
danishashko wants to merge 1 commit intoeliasdabbas:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
sitemap_to_dfrecurses (both for robots.txt sitemap lists and for sitemap index files),request_headersandmax_workersare silently dropped. This means custom headers (auth tokens, user-agent) and thread counts only apply to the top-level call.This fix passes them through on both recursive call sites so they propagate consistently through the whole crawl.