fix(core): prevent duplicate LLM calls when message contains URL or triggers providers

[nicolasdma]

Relates to

Relates to #6486

Risks

Low — single condition removed from a boolean expression. No new code, no new logic paths.

Background

What does this PR do?

Removes the providers.length check from the isSimple determination in packages/typescript/src/services/message.ts.

What kind of change is this?

Bug fix (non-breaking change that fixes an issue).

Changes

When a user sends a message containing a URL, the LLM's first call (via runSingleShotCore) generates and streams the response text. It also returns providers: ["ATTACHMENTS"] because the prompt template instructs it to when it sees URLs.

The isSimple check at line 1883 previously treated "has providers" as "not simple":

const isSimple =
    responseContent?.actions &&
    responseContent.actions.length === 1 &&
    typeof responseContent.actions[0] === "string" &&
    responseContent.actions[0].toUpperCase() === "REPLY" &&
    (!responseContent.providers || responseContent.providers.length === 0);
//   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
//   This condition causes the bug

This caused the message to go through the actions path, which triggered the REPLY action handler (reply.ts:60), making a second LLM call with replyTemplate and streaming another response — duplicating output and doubling token costs.

The fix: Remove the providers check. Providers enrich state (already handled at L863-871) but don't require re-generating the response. isSimple should only care about whether the action is REPLY (text already generated and streamed) vs something else (needs execution).

const isSimple =
    responseContent?.actions &&
    responseContent.actions.length === 1 &&
    typeof responseContent.actions[0] === "string" &&
    responseContent.actions[0].toUpperCase() === "REPLY";

Testing

• Message with URL → single response (not duplicated)
• Message without URL → works as before
• Multi-action messages (REPLY + other) → still trigger actions path
• Messages with non-REPLY actions → still trigger actions path

Greptile Summary

Removes the providers.length check from the isSimple boolean expression, preventing duplicate LLM calls when messages contain URLs or trigger provider enrichment.

Key Changes:

• Removed condition (!responseContent.providers || responseContent.providers.length === 0) from isSimple check at line 1883
• Messages with actions: ["REPLY"] now correctly use the "simple" path regardless of provider presence
• Providers still enrich state (lines 863-871) but no longer force re-generation of already-streamed responses

Impact:

• Eliminates duplicate streaming when URLs are detected (previously triggered ATTACHMENTS provider → action path → second LLM call)
• Reduces token costs by avoiding unnecessary second LLM invocation
• Response text from first runSingleShotCore call is now correctly used as final output

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• Simple, surgical fix that removes a single condition causing unintended behavior. The logic is sound: providers enrich state (already handled separately at L863-871) but shouldn't force action-based execution when the response is already generated and streamed. No new code paths, no breaking changes.
• No files require special attention

Important Files Changed

Filename	Overview
packages/typescript/src/services/message.ts	Removed providers check from isSimple determination to prevent duplicate LLM calls when URLs trigger provider enrichment

_{Last reviewed commit: 681b3d8}

_{(2/5) Greptile learns from your feedback when you react with thumbs up/down!}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

[odilitime]

if it has providers, it's not simple. That is correct.

[nicolasdma]

The ATTACHMENTS provider gets set during the initial runSingleShotCore pass (after URL detection).
But by the time we evaluate isSimple, the reply has already been generated and streamed.

In reply.ts around line 70: is the second LLM call expected when actions: ["REPLY"] and providers are present?
Right now I’m seeing duplicated output and ~2x token usage. If that’s intentional, I can close this PR