Add picoads - AI Agent Ad Marketplace#293
Add picoads - AI Agent Ad Marketplace#293ililic wants to merge 1 commit intoelizaos-plugins:mainfrom
Conversation
WalkthroughAdded a new package mapping entry for "@picoads/eliza-plugin" pointing to a GitHub repository in index.json. No other changes or removals. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan for PR comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "@mazzz/plugin-elizaos-compchembridge": "github:Mazzz-zzz/plugin-elizaos-compchembridge", | ||
| "@nuggetslife/plugin-nuggets": "github:NuggetsLtd/eliza-plugin-nuggets", | ||
| "@onbonsai/plugin-bonsai": "github:onbonsai/plugin-bonsai", | ||
| "@picoads/eliza-plugin": "github:picoads/eliza-plugin", |
There was a problem hiding this comment.
Generic plugin name deviates from registry convention
Most entries in this registry follow the @org/plugin-<functionality> naming pattern (e.g. @mazzz/plugin-elizaos-compchembridge, @nuggetslife/plugin-nuggets, @onbonsai/plugin-bonsai). Both the NPM package name and the GitHub repo here use the suffix eliza-plugin, which is generic and doesn't communicate what the plugin actually does (Ad Marketplace / PicoAds).
A more descriptive name such as @picoads/plugin-picoads or @picoads/plugin-ads would better align with the convention and make the registry entry self-documenting. There is a precedent with @proofgate/eliza-plugin, but that shouldn't prevent new entries from following the preferred pattern.
Consider renaming the NPM package and GitHub repo before merging.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Registry Update Checklist
Registry:
If not an eliza-plugins official repo, i.e. new plugin:
The plugin repo has:
elizaos-pluginsin the topics in the GitHub repo settings. If the plugin is related toAIorcrypto, please add those as topics as well.images/banner.jpgandimages/logo.jpgand they{ "name": "@myNpmOrg/plugin-example", "version": "1.0.0", "agentConfig": { "pluginType": "elizaos:plugin:1.0.0", "pluginParameters": { "API_KEY": { "type": "string", "description": "API key for the service" } } } }Summary by CodeRabbit
Release Notes
Greptile Summary
This PR registers a new plugin entry
@picoads/eliza-plugin(pointing togithub:picoads/eliza-plugin) in the ElizaOS plugin registry. The change is a single-line addition toindex.json.Checklist observations:
@onbonsai/plugin-bonsaiand@proofgate/eliza-plugin("pi" sorts between "on" and "pr").github:scheme is used (notgithub.com:), and there is no.gitsuffix.@picoads/eliza-plugin) matches what would be the NPM package name.Minor concern:
eliza-pluginrather than a descriptive plugin name (e.g.plugin-picoadsorplugin-picoads-ads). While there is a precedent in the registry (e.g.@proofgate/eliza-plugin), adopting a more descriptive name would better align with the dominantplugin-<functionality>naming convention used throughout the registry. This is not a blocker but worth noting.Confidence Score: 4/5
eliza-pluginrather than a descriptive plugin name, which is a minor convention deviation worth reviewing before merging.index.json.Important Files Changed
@picoads/eliza-pluginregistry entry pointing togithub:picoads/eliza-plugin. JSON is well-formed, alphabetical ordering is correct, and thegithub:scheme is used without a.gitextension. Minor concern: the repo/package nameeliza-pluginis generic and doesn't describe the plugin's functionality.Sequence Diagram
sequenceDiagram participant Dev as Developer participant Registry as elizaos-plugins/registry (index.json) participant NPM as @picoads/eliza-plugin (NPM) participant GH as github:picoads/eliza-plugin Dev->>Registry: Add entry "@picoads/eliza-plugin" Registry-->>NPM: Resolves package name Registry-->>GH: Points to GitHub source NPM->>GH: Install / resolve sourceLast reviewed commit: fbab0f6