Skip to content

Add picoads - AI Agent Ad Marketplace#293

Open
ililic wants to merge 1 commit intoelizaos-plugins:mainfrom
ililic:main
Open

Add picoads - AI Agent Ad Marketplace#293
ililic wants to merge 1 commit intoelizaos-plugins:mainfrom
ililic:main

Conversation

@ililic
Copy link

@ililic ililic commented Mar 12, 2026

Registry Update Checklist

Registry:

  • [ ✅ ] I've made the left side of the colon of JSON entry in index.json match the potential NPM package name
  • [ ✅ ] I've used github not github.com
  • [ ✅ ] There is no .git extension
  • [ ✅ ] It's placed it alphabetically in the list
  • [ ✅ ] I've dealt with commas properly so the list is still valid JSON

If not an eliza-plugins official repo, i.e. new plugin:

The plugin repo has:

  • [ ✅ ] is publically accessible (not a private repo)
  • [ ✅ ] uses main as it's default branch
  • [ ✅ ] I have include elizaos-plugins in the topics in the GitHub repo settings. If the plugin is related to AI or crypto, please add those as topics as well.
  • [ ✅ ] add simple description in github repo
  • [ ✅ ] follows this convention
plugin-name/
├── images/
│   ├── logo.jpg        # Plugin branding logo
│   ├── banner.jpg      # Plugin banner image
├── src/
│   ├── index.ts        # Main plugin entry point
│   ├── actions/        # Plugin-specific actions
│   ├── clients/        # Client implementations
│   ├── adapters/       # Adapter implementations
│   └── types.ts        # Type definitions
│   └── environment.ts  # runtime.getSetting, zod validation
├── package.json        # Plugin dependencies
└── README.md          # Plugin documentation
  • [ ✅ ] an images/banner.jpg and images/logo.jpg and they
    • Use clear, high-resolution images
    • Keep file sizes optimized (< 500KB for logos, < 1MB for banners)
    • Follow the elizaOS Brand Guidelines
    • Include alt text for accessibility
  • [ ✅ ] package.json has a agentConfig like the following
{
  "name": "@myNpmOrg/plugin-example",
  "version": "1.0.0",
  "agentConfig": {
    "pluginType": "elizaos:plugin:1.0.0",
    "pluginParameters": {
      "API_KEY": {
        "type": "string",
        "description": "API key for the service"
      }
    }
  }
}

Summary by CodeRabbit

Release Notes

  • New Features
    • Added support for the Eliza plugin, expanding available integrations.

Greptile Summary

This PR registers a new plugin entry @picoads/eliza-plugin (pointing to github:picoads/eliza-plugin) in the ElizaOS plugin registry. The change is a single-line addition to index.json.

Checklist observations:

  • JSON syntax is valid and commas are correctly placed.
  • The entry is correctly alphabetised between @onbonsai/plugin-bonsai and @proofgate/eliza-plugin ("pi" sorts between "on" and "pr").
  • The github: scheme is used (not github.com:), and there is no .git suffix.
  • The package name key (@picoads/eliza-plugin) matches what would be the NPM package name.

Minor concern:

  • Both the NPM package name and the GitHub repo use the generic suffix eliza-plugin rather than a descriptive plugin name (e.g. plugin-picoads or plugin-picoads-ads). While there is a precedent in the registry (e.g. @proofgate/eliza-plugin), adopting a more descriptive name would better align with the dominant plugin-<functionality> naming convention used throughout the registry. This is not a blocker but worth noting.

Confidence Score: 4/5

  • This PR is safe to merge; it adds a single well-formed registry entry with no structural issues.
  • The change is minimal (one line in index.json), JSON syntax is valid, ordering is correct, and formatting conventions are followed. A point is deducted because the plugin and repo both use the generic name eliza-plugin rather than a descriptive plugin name, which is a minor convention deviation worth reviewing before merging.
  • No files require special attention beyond the minor naming convention note in index.json.

Important Files Changed

Filename Overview
index.json Adds @picoads/eliza-plugin registry entry pointing to github:picoads/eliza-plugin. JSON is well-formed, alphabetical ordering is correct, and the github: scheme is used without a .git extension. Minor concern: the repo/package name eliza-plugin is generic and doesn't describe the plugin's functionality.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Registry as elizaos-plugins/registry (index.json)
    participant NPM as @picoads/eliza-plugin (NPM)
    participant GH as github:picoads/eliza-plugin

    Dev->>Registry: Add entry "@picoads/eliza-plugin"
    Registry-->>NPM: Resolves package name
    Registry-->>GH: Points to GitHub source
    NPM->>GH: Install / resolve source
Loading

Last reviewed commit: fbab0f6

Greptile also left 1 inline comment on this PR.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 12, 2026

Walkthrough

Added a new package mapping entry for "@picoads/eliza-plugin" pointing to a GitHub repository in index.json. No other changes or removals.

Changes

Cohort / File(s) Summary
Package Mapping Addition
index.json
Added new dependency mapping: "@picoads/eliza-plugin" → "github:picoads/eliza-plugin"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A plugin arrives from GitHub's distant shore,
@picoads-eliza, we welcome you once more,
In index.json, your mapping takes its stand,
One simple line makes everything so grand! ✨
Hopping forward, our ecosystem grows. 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a new plugin entry for picoads to the registry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description follows the required template structure with all checklist items completed and marked as verified.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan for PR comments
  • Generate coding plan

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

"@mazzz/plugin-elizaos-compchembridge": "github:Mazzz-zzz/plugin-elizaos-compchembridge",
"@nuggetslife/plugin-nuggets": "github:NuggetsLtd/eliza-plugin-nuggets",
"@onbonsai/plugin-bonsai": "github:onbonsai/plugin-bonsai",
"@picoads/eliza-plugin": "github:picoads/eliza-plugin",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generic plugin name deviates from registry convention

Most entries in this registry follow the @org/plugin-<functionality> naming pattern (e.g. @mazzz/plugin-elizaos-compchembridge, @nuggetslife/plugin-nuggets, @onbonsai/plugin-bonsai). Both the NPM package name and the GitHub repo here use the suffix eliza-plugin, which is generic and doesn't communicate what the plugin actually does (Ad Marketplace / PicoAds).

A more descriptive name such as @picoads/plugin-picoads or @picoads/plugin-ads would better align with the convention and make the registry entry self-documenting. There is a precedent with @proofgate/eliza-plugin, but that shouldn't prevent new entries from following the preferred pattern.

Consider renaming the NPM package and GitHub repo before merging.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant