Add @jonathanbulkeley/plugin-mycelia-signal#298
Add @jonathanbulkeley/plugin-mycelia-signal#298jonathanbulkeley wants to merge 1 commit intoelizaos-plugins:mainfrom
Conversation
Add @jonathanbulkeley/plugin-mycelia-signal
WalkthroughA new plugin mapping for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| "@esscrypt/plugin-polkadot": "github:Esscrypt/plugin-polkadot", | ||
| "@kamiyo/eliza": "github:kamiyo-ai/kamiyo-protocol#main:packages/kamiyo-eliza", | ||
| "@kudo-dev/plugin-kudo": "github:Kudo-Archi/plugin-kudo", | ||
| "@jonathanbulkeley/plugin-mycelia-signal": "github:jonathanbulkeley/elizaos-plugin-mycelia-signal", |
There was a problem hiding this comment.
Entry is not in alphabetical order. The entry @jonathanbulkeley/plugin-mycelia-signal is currently placed after @kudo-dev/plugin-kudo, but alphabetically j < k, so it should appear before @kamiyo/eliza (after @esscrypt/plugin-polkadot on line 226). Please move it to maintain the required alphabetical sorting.
| "@jonathanbulkeley/plugin-mycelia-signal": "github:jonathanbulkeley/elizaos-plugin-mycelia-signal", | |
| "@mascotai/plugin-connections": "github:mascotai/plugin-connections", |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
index.json (1)
227-230: Keep plugin keys alphabetically ordered around the new entry.Line 229 adds the correct mapping, but its position breaks the local sort order (
@jonathan...should be before@kamiyo.../@kudo...). Reordering keeps diffs predictable and reduces future merge churn.♻️ Proposed reorder
- "@kamiyo/eliza": "github:kamiyo-ai/kamiyo-protocol#main:packages/kamiyo-eliza", - "@kudo-dev/plugin-kudo": "github:Kudo-Archi/plugin-kudo", "@jonathanbulkeley/plugin-mycelia-signal": "github:jonathanbulkeley/elizaos-plugin-mycelia-signal", + "@kamiyo/eliza": "github:kamiyo-ai/kamiyo-protocol#main:packages/kamiyo-eliza", + "@kudo-dev/plugin-kudo": "github:Kudo-Archi/plugin-kudo",🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@index.json` around lines 227 - 230, The plugin mapping entries in index.json are out of alphabetical order; move the "@jonathanbulkeley/plugin-mycelia-signal": "github:jonathanbulkeley/elizaos-plugin-mycelia-signal" entry so it appears before "@kamiyo/eliza" and "@kudo-dev/plugin-kudo" to restore local alphabetical order of keys; ensure the surrounding plugin keys remain unchanged and that commas/JSON formatting are preserved after the reorder.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@index.json`:
- Around line 227-230: The plugin mapping entries in index.json are out of
alphabetical order; move the "@jonathanbulkeley/plugin-mycelia-signal":
"github:jonathanbulkeley/elizaos-plugin-mycelia-signal" entry so it appears
before "@kamiyo/eliza" and "@kudo-dev/plugin-kudo" to restore local alphabetical
order of keys; ensure the surrounding plugin keys remain unchanged and that
commas/JSON formatting are preserved after the reorder.
Mycelia Signal sovereign price oracle plugin for ElizaOS.
Summary by CodeRabbit
Greptile Summary
This PR adds
@jonathanbulkeley/plugin-mycelia-signalto the plugin registry — a sovereign price oracle plugin providing crypto, FX, commodities, and economic indicator data via Lightning/USDC payments.jonathanbulkeley/elizaos-plugin-mycelia-signal) exists and is publicly accessible@kudo-dev/plugin-kudo(line 229) but should be placed after@esscrypt/plugin-polkadot(line 226), since@jonathanbulkeleysorts before@kamiyoand@kudo-devConfidence Score: 2/5
index.json— the new entry on line 229 needs to be moved to line 227 (after@esscrypt/plugin-polkadot) to maintain alphabetical order.Important Files Changed
@jonathanbulkeley/plugin-mycelia-signalis after@kudo-dev/plugin-kudobut should be after@esscrypt/plugin-polkadot(j < k). GitHub repo exists and is accessible.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A["PR: Add plugin entry to index.json"] --> B["index.json updated"] B --> C["CI: Validate JSON format ✅"] B --> D["CI: Check alphabetical sort ❌"] B --> E["CI: Verify GitHub repo exists ✅"] B --> F["CI: Verify NPM package exists"] D --> G["Entry @jonathanbulkeley/plugin-mycelia-signal\nis after @kudo-dev but should be before @kamiyo"] G --> H["Fix: Move entry to correct position\n(after @esscrypt/plugin-polkadot)"] H --> I["Auto-generate registry on merge"] I --> J["generated-registry.json updated"]Last reviewed commit: a41db20
(3/5) Reply to the agent's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!