fix: resolve static paths correctly on Windows

[denysovvl]

Summary by CodeRabbit

• Bug Fixes

  • Enhanced path normalization to improve cross-platform compatibility, ensuring consistent URL routing and asset serving behavior on Windows and Unix-based systems.

• Style

  • Minor code formatting adjustment.

[coderabbitai]

Walkthrough

Path normalization for Windows-style file separators is added to src/index.ts. A normalizedPath constant converts backslashes to forward slashes from the original pathName, and this normalized path is consistently applied across route registrations and HTML file checks to ensure cross-platform path handling.

Changes

Cohort / File(s)	Summary
Path normalization for cross-platform routing src/index.ts	Introduces normalizedPath constant that normalizes Windows-style path separators to POSIX format. Applies normalization consistently in route handlers, static file serving, Bun HTML handling, and index.html path checks. Includes minor syntax unwrapping of a ternary expression around fastDecodeURI().

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

The changes are homogeneous (consistent pattern application across multiple code paths in a single file) and straightforward—replacing path separators and normalizing routes. Review focuses on verifying the normalization is applied uniformly across all affected branches and that no instances were missed.

Poem

🐰 Windows and Unix, at last they align,
With forward slashes, the paths intertwine,
Cross-platform harmony, backslashes gone,
Routes normalized—let the servers march on! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The PR title "fix: resolve static paths correctly on Windows" directly aligns with the primary objective of the changeset. The changes involve normalizing Windows-style file paths (converting backslashes to forward slashes) to ensure POSIX-style URL paths across multiple code branches handling static file serving and HTML asset resolution. The title accurately captures this core fix and clearly communicates the Windows-specific path resolution improvement. The title is concise, uses appropriate commit conventions, and avoids vague terminology, making it immediately understandable to reviewers scanning the pull request history.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/index.ts (1)

84-96: LGTM! Path normalization correctly fixes Windows route registration.

The normalization converts Windows backslashes to forward slashes before registering routes with Elysia, ensuring cross-platform compatibility. The logic correctly handles both the main route and the index.html fallback route.

Consider extracting the normalization logic into a helper function to reduce duplication (also appears at lines 185 and 231):

const normalizeRoutePath = (pathName: string) => pathName.replace(/\\/g, '/')

Then use:

-const normalizedPath = pathName.replace(/\\/g, '/')
+const normalizedPath = normalizeRoutePath(pathName)

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 516491c and 6b58da2.

📒 Files selected for processing (1)

• src/index.ts (5 hunks)

🔇 Additional comments (3)

src/index.ts (3)

185-213: LGTM! Normalization correctly applied to static file routes.

The path normalization is properly integrated with the caching logic. Cache keys intentionally use pathName (file system paths) while route registration uses normalizedPath (URL paths), which is the correct approach.

---

223-240: LGTM! Bun HTML routes correctly use normalized paths.

The normalization is consistently applied in the Bun HTML handling branch, matching the pattern used in the alwaysStatic branch.

---

249-249: LGTM! Minor formatting cleanup.

The ternary expression formatting change is purely stylistic with no functional impact.