Skip to content

Make mysql work for some special cases (database case, views, foreign keys) #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make mysql work for some special cases (database case, views, foreign keys) #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b8f85d
Make mysql work for databases that are not all lowercase
Feb 28, 2017
d68d41f
Don't try to truncate views in MySQL
Mar 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 40 additions & 31 deletions lib/database-cleaner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,45 +47,54 @@ var DatabaseCleaner = module.exports = function(type, config) {
};

cleaner['mysql'] = function(db, callback) {
db.query('show tables', function(err, tables) {
db.query('SET FOREIGN_KEY_CHECKS = 0', function(err) {
if (err) return callback(err);

var database = db.config.connectionConfig ?
db.config.connectionConfig.database : db.config.database;
db.query('show global variables like "lower_case_table_names"', function(err, values) {

var count = 0;
var length = tables.length;
var tableName = 'Tables_in_' + database;
var skippedTables = config.mysql.skipTables;
var strategy = config.mysql.strategy || 'deletion';
if (strategy !== 'deletion' && strategy !== 'truncation') {
return callback(new Error('Invalid deletion strategy: ' + strategy));
}
var lowerCaseTableNames = values[0]['Value'] === 2;

if(length === 0) {
// The database is empty
return callback();
}
db.query('show full tables where Table_Type != "VIEW"', function(err, tables) {
if (err) return callback(err);

tables.forEach(function(table) {
if (skippedTables.indexOf(table[tableName]) === -1) {
var statement = strategy === 'deletion' ? 'DELETE FROM ' : 'TRUNCATE TABLE '
db.query(statement + table[tableName], function(err) {
if(err) {
return callback(err);
}
var database = db.config.connectionConfig ?
db.config.connectionConfig.database : db.config.database;

count++;
if (count >= length) {
callback();
var count = 0;
var length = tables.length;
var tableName = 'Tables_in_' + (lowerCaseTableNames ? database.toLowerCase() : database);
var skippedTables = config.mysql.skipTables;
var strategy = config.mysql.strategy || 'deletion';
if (strategy !== 'deletion' && strategy !== 'truncation') {
return callback(new Error('Invalid deletion strategy: ' + strategy));
}

if(length === 0) {
// The database is empty
return callback();
}

tables.forEach(function(table) {
if (skippedTables.indexOf(table[tableName]) === -1) {
var statement = (strategy === 'deletion') ? 'DELETE FROM ' : 'TRUNCATE TABLE ';
db.query(statement + table[tableName], function(err) {
if(err) {
return callback(err);
}

count++;
if (count >= length) {
callback();
}
});
} else {
count++;
if (count >= length) {
callback();
}
}
});
} else {
count++;
if (count >= length) {
callback();
}
}
});
});
});
};
Expand Down
21 changes: 9 additions & 12 deletions test/mysql.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,25 +4,22 @@ var should = require('should'),
async = require('async'),
databaseCleaner;

var config = {
host: process.env.MYSQL_HOST || 'localhost',
user: 'root',
database: 'database_cleaner'
}
var mysql = require('mysql'),
client = new mysql.createConnection({
host: process.env.MYSQL_HOST || 'localhost',
user: 'root',
database: 'database_cleaner'
}),
pool = new mysql.createPool({
host: process.env.MYSQL_HOST || 'localhost',
user: 'root',
database: 'database_cleaner'
});
client = new mysql.createConnection(config),
pool = new mysql.createPool(config);

var queryClient = _.curry(function(query, values, next) {
client.query(query, values, next);
});

describe('mysql', function() {
beforeEach(function(done) {
client.query('CREATE DATABASE database_cleaner', function(err) {
client.query('CREATE DATABASE ' + config.database, function(err) {
if (err && err.number != mysql.ERROR_DB_CREATE_EXISTS) {
throw err;
}
Expand Down Expand Up @@ -145,7 +142,7 @@ describe('mysql', function() {

describe('mysql empty', function() {
beforeEach(function(done) {
client.query('CREATE DATABASE database_cleaner', function(err) {
client.query('CREATE DATABASE ' + config.database, function(err) {
if (err && err.number != mysql.ERROR_DB_CREATE_EXISTS) {
throw err;
}
Expand Down