#5 - adds support for properties with multiple values #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
=========================================
+ Coverage 82.45% 83.2% +0.74%
=========================================
Files 4 4
Lines 359 375 +16
=========================================
+ Hits 296 312 +16
Misses 46 46
Partials 17 17
Continue to review full report at Codecov.
|
emersion
requested changes
Oct 30, 2018
Owner
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
Thanks for your PR, sorry for the delay.
I also need to read again the RFC to make sure we can do this on all fields.
|
|
||
| func parseLine(l string) (key string, field *Field, err error) { | ||
| field = new(Field) | ||
| const placeholder = "\uFFFD" |
Owner
There was a problem hiding this comment.
Instead of using a placeholder (which could be in the input), can we replace this logic with a proper char-by-char parser?
This was referenced Oct 22, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.