Google Glass and Pixel 3XL Support #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the changes necessary to get things running on my particular setup. I tried to keep the tweaks fairly minimal, the primary goal to just get things up and running. Google Glass ============ Google Glass' XE24 update (their final update) uses API 19, so I had to backport the `minSdkVersion` and make some minor tweaks to call `getDrawable` through the resource instead of directly. Additionally, to navigate to the app, a glass specific intent-filter action had to be added. I believe this should just be ignored in other contexts, but somebody with a different pair of glasses will need to test this. Pixel 3XL (Android 12) ====================== I'm uncertain what the original intent behind the code was in `isHotspotOn`, but `getDeclaredMethods()` caused the app to crash when running on my phone. Calling the method directly, though, seemed to work fine, so I just shifted it to the more direct approach. It seemed like primarily it was just calling `isWifiApEnabled`, but maybe there are important use cases I'm bypassing with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the changes necessary to get things running on my particular setup. I tried to keep the tweaks fairly minimal, the primary goal to just get things up and running.
Google Glass
Google Glass' XE24 update (their final update) uses API 19, so I had to backport the
minSdkVersionand make some minor tweaks to callgetDrawablethrough the resource instead of directly.Additionally, to navigate to the app, a glass specific intent-filter action had to be added. I believe this should just be ignored in other contexts, but somebody with a different pair of glasses will need to test this.
Pixel 3XL (Android 12)
I'm uncertain what the original intent behind the code was in
isHotspotOn, butgetDeclaredMethods()caused the app to crash when running on my phone. Calling the method directly, though, seemed to work fine, so I just shifted it to the more direct approach. It seemed like primarily it was just callingisWifiApEnabled, but maybe there are important use cases I'm bypassing with this approach.