Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
==========================================
+ Coverage 74.78% 76.90% +2.11%
==========================================
Files 63 66 +3
Lines 15062 17065 +2003
==========================================
+ Hits 11264 13123 +1859
- Misses 3798 3942 +144 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ith coroutines - Created a new QUIC client example in - Updated `simple_client` to utilize Kotlin coroutines for asynchronous event handling
- Add enable_key_log field to MqttTlsOptionsFFI for TLS key logging - Wire enable_key_log through Kotlin/C FFI bindings (enableKeyLog) - Enable rustls::KeyLogFile when enable_key_log is true - Set QUIC max_idle_timeout to 120 seconds to prevent premature
There was a problem hiding this comment.
Pull request overview
This PR introduces Kotlin/UniFFI support for the FlowSDK FFI layer and adds TLS key logging support across bindings, along with a QUIC transport tweak to reduce premature idle timeouts.
Changes:
- Add Kotlin Gradle multi-module project (package + TCP/QUIC examples) plus CI job and build script to generate/build Kotlin bindings.
- Extend TLS options in the FFI (Rust + Python + C examples) to support optional TLS key logging (Wireshark via
SSLKEYLOGFILE). - Set a QUIC
max_idle_timeoutin the Rust QUIC MQTT engine transport config.
Reviewed changes
Copilot reviewed 21 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mqtt_client/engine.rs | Configures QUIC transport idle timeout to better align with MQTT keepalive behavior. |
| scripts/build_kotlin_bindings.sh | Adds a helper script to build the FFI library (QUIC feature) and generate Kotlin bindings, then build Gradle modules. |
| python/package/flowsdk/async_client.py | Plumbs enable_key_log through Python async client into FFI TLS options. |
| python/examples/asyncio_tls_client_example.py | Enables TLS key logging in the example based on SSLKEYLOGFILE. |
| python/examples/asyncio_quic_client_example.py | Documents and enables TLS key logging in the QUIC example based on SSLKEYLOGFILE. |
| kotlin/settings.gradle.kts | Declares Kotlin multi-module build (package + examples). |
| kotlin/package/build.gradle.kts | Defines Kotlin package module with JNA dependency and Java toolchain settings. |
| kotlin/gradlew.bat | Adds Gradle wrapper for Windows. |
| kotlin/gradlew | Adds Gradle wrapper for POSIX. |
| kotlin/gradle/wrapper/gradle-wrapper.properties | Configures Gradle wrapper distribution (8.7). |
| kotlin/gradle/wrapper/gradle-wrapper.jar | Adds Gradle wrapper JAR. |
| kotlin/examples/simple_client/src/main/kotlin/Main.kt | Adds a TCP MQTT example using the Kotlin FFI bindings. |
| kotlin/examples/simple_client/build.gradle.kts | Adds Gradle config for the TCP example module. |
| kotlin/examples/quic_client/src/main/kotlin/Main.kt | Adds a QUIC MQTT example using Kotlin FFI bindings and TLS options. |
| kotlin/examples/quic_client/README.md | Documents building/running the QUIC Kotlin example and TLS key logging. |
| kotlin/examples/quic_client/build.gradle.kts | Adds Gradle config for the QUIC example module. |
| kotlin/build.gradle.kts | Adds root Kotlin build config and Kotlin plugin version. |
| flowsdk_ffi/src/engine/ffi_types.rs | Extends MqttTlsOptionsFFI with enable_key_log. |
| flowsdk_ffi/src/engine.rs | Implements TLS key log enabling in Rustls configs for TLS and QUIC engines; wires through C options. |
| examples/c_ffi_example/tls_main.c | Enables TLS key logging in the C TLS example when SSLKEYLOGFILE is set. |
| examples/c_ffi_example/quic_main.c | Enables TLS key logging in the C QUIC example when SSLKEYLOGFILE is set. |
| .gitignore | Adds ignores for Kotlin build artifacts and TLS keylog files. |
| .github/workflows/ci.yml | Adds Kotlin bindings CI job and pins Rust toolchain action to a commit SHA in several jobs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Kotlin FFI support and example code also support dumping TLS keylogfile for troubleshooting in other FFIs
Fixes #(issue)