Implement SQLite Engine #6
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sqlite engine implementation,
I believe some changes to the config was necessary,
When getting value from a sql based database we need the table which the end user needs to specify so I have added that in.
When setting value we need the table and the column to write to the database, can be implemented without the column, but better be safe than sorry.
When creating a new database connection, crate creates a new database, so a typo could be a problem, maybe we can add some sort of validation.
Let me know if you want me to add or change stuff.
I didn't touch the readme for now, I can change the readme for sqlite as well just wanted to be sure with the implementations.