Skip to content

Change standalone wasm vm tests to emit a test skip when wasm engine is not present #24631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 14, 2025
+4 −1
Merged

Change standalone wasm vm tests to emit a test skip when wasm engine is not present #24631

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
850f309
Change standalone wasm vm tests to emit a test skip when wasm engine …
juj Jun 28, 2025
d6675f4
Address review
juj Aug 13, 2025
449adf2
Fail instead of warn
juj Aug 13, 2025
ed70fe4
Revert back to a warning
juj Aug 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1995,7 +1995,10 @@ def _build_and_run(self, filename, expected_output, args=None,
# TODO once standalone wasm support is more stable, apply use_all_engines
# like with js engines, but for now as we bring it up, test in all of them
if not self.wasm_engines:
logger.warning('no wasm engine was found to run the standalone part of this test')
if 'EMTEST_SKIP_WASM_ENGINE' in os.environ:
self.skipTest('no wasm engine was found to run the standalone part of this test')
else:
logger.warning('no wasm engine was found to run the standalone part of this test (Use EMTEST_SKIP_WASM_ENGINE to skip)')
engines += self.wasm_engines
if len(engines) == 0:
self.fail('No JS engine present to run this test with. Check %s and the paths therein.' % config.EM_CONFIG)
Expand Down